Run tests on PHP 8.3, fix dynamic property for PHP 8.2 and update test suite#40
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
yadaiio commented Apr 23, 2024
Uh oh!
There was an error while loading. Please reload this page.
SimonFrings requested review from SimonFrings and clue and removed request for clue
yadaiio changed the title 
SimonFrings approved these changes Apr 26, 2024
Contributor
SimonFrings left a comment
SimonFrings left a comment There was a problem hiding this comment.
The dynamic property seems to be an oversight from #37, thanks for fixing this 👍
clue reviewed May 1, 2024
Uh oh!
There was an error while loading. Please reload this page.
yadaiioforce-pushed the test_suite branch 2 times, most recently from 06215b9 to 68edc2cCompareSimonFrings approved these changes Jun 10, 2024
clue reviewed Jun 16, 2024
Uh oh!
There was an error while loading. Please reload this page.
Author
yadaiio commented Jun 28, 2024
As today is my last day working with you @clue, we agreed closing this pull request and revisit this later on. If anyone is needing these changes earlier than expected, please consider sponsoring @clue via https://github.com/sponsors/clue. ❤️ |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #32, #37 and #39.
References: reactphp/socket#300, clue/reactphp-zenity#63, clue/reactphp-csv#33 and others.
The tests were failing in PHP 5.3 because of an unknown
React\Promise\Timer\sleep()function. In order to avoid this I updated this to use theReact\Async\delay()function instead.Additionally I saw the dynamic properties were deprecated since PHP 8.2, see https://www.php.net/releases/8.2/en.php#deprecate_dynamic_properties, so I had to add a new class variable in the
CompositeConnection.phpfile to avoid that the test for PHP 8.2 and PHP 8.3 run infinitely.