Update test environment to report failed assertions#300
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
SimonFrings approved these changes Oct 25, 2022
clueforce-pushed the assert branch 5 times, most recently from 1a5fd42 to 84e1373Compare
MemberAuthor
clue commented Oct 26, 2022
I've updated this to work around a super nasty bug in reactphp/async v4. Until this is fixed upstream (see reactphp/async#65), the work around already allows us to merge this as is. This work around can be removed again once fixed upstream, but it should not cause any issues in either case. Together with the changes upstream, you're looking at ~6h of work to achieve what should have been pretty much only a configuration change, enjoy! This is now ready for review. |
SimonFrings approved these changes Oct 26, 2022
WyriHaximus approved these changes Oct 29, 2022
This was referenced Oct 30, 2022
This was referenced Nov 13, 2022
This was referenced Nov 15, 2023
This was referenced Nov 24, 2023
This was referenced Dec 19, 2023
This was referenced Jan 17, 2024
This was referenced Apr 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #299 and clue/framework-x#199
Refs shivammathur/setup-php#582 and shivammathur/setup-php#450