fix semver not fully covered#1548

bearomorphism · 2025-06-12T19:14:14Z

Description

Related issue: #950

Checklist

I have read the contributing guidelines
Better/correct test cases

bearomorphism · 2025-06-12T19:27:59Z

tests/test_version_scheme_semver.py

+ (("1.0.0-reallyweird", "PATCH", "reallyweird", 0, None), "1.0.0-reallyweird1"),
+ (("v0.7.1-release", "PATCH", "release", 0, None), "0.7.1-release1"),
+ (("v0.0.1-SNAPSHOT", "PATCH", "SNAPSHOT", 0, None), "0.0.1-snapshot1"),


@Lee-W I'm not entirely sure if these test cases are correct. Could you help to review?

codecov · 2025-06-13T13:11:34Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.25%. Comparing base (120d514) to head (bb48144).
⚠️ Report is 805 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #1548 +/- ## ========================================== + Coverage 97.33% 98.25% +0.91%  ========================================== Files 42 58 +16 Lines 2104 2696 +592 ========================================== + Hits 2048 2649 +601 + Misses 56 47 -9

Flag	Coverage Δ
unittests	`98.25% <100.00%> (+0.91%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Lee-W · 2025-08-24T10:17:44Z

tests/test_version_scheme_semver.py

+ (("1.0.0-reallyweird", "PATCH", "reallyweird", 0, None), "1.0.0-reallyweird1"),
+ (("v0.7.1-release", "PATCH", "release", 0, None), "0.7.1-release1"),
+ (("v0.0.1-SNAPSHOT", "PATCH", "SNAPSHOT", 0, None), "0.0.1-snapshot1"),


Suggested change
(("1.0.0-reallyweird", "PATCH", "reallyweird", 0, None), "1.0.0-reallyweird1"),
(("v0.7.1-release", "PATCH", "release", 0, None), "0.7.1-release1"),
(("v0.0.1-SNAPSHOT", "PATCH", "SNAPSHOT", 0, None), "0.0.1-snapshot1"),
(("1.0.0-reallyweird", "PATCH", "reallyweird", 0, None), "1.0.1-reallyweird1"),
(("v0.7.1-release", "PATCH", "release", 0, None), "0.7.2-release1"),
(("v0.0.1-SNAPSHOT", "PATCH", "SNAPSHOT", 0, None), "0.0.2-snapshot1"),
I feel they probably should be this instead?

I need some time to figure out how to adjust the logic.

Isn't the version number already appended at the end of the version string?

@Lee-W a gentle reminder for this discussion

I honestly don't remember... @woile any idea?

also it might be a good idea to make these named tuple. too hard to read...

I agree the tests can be more readable. I had #1598 that attempts to make the tests read better.
I can make the NamedTuple change in that PR.

Lee-W · 2025-08-24T10:18:17Z

commitizen/version_schemes.py


+# See https://github.com/pypa/packaging/blob/14b83e15dbb9caa87c63646ba7808b2b5e460ce6/src/packaging/version.py#L117
+# TODO: add more test cases for this pattern
+_VERSION_PATTERN=r"""^\s*


One thing to note is that Python does not use semver. It exists before semver

Should I add any comments here?

not a bad idea. more like a reminder that we can not fully depend on python packaging version

bearomorphism · 2025-09-08T06:45:49Z

I will update this PR this week when I have bandwidth

bearomorphism · 2025-09-09T10:28:24Z

Maybe we can adjust the workflow. Several PRs got closed just because the target branch is deleted

Lee-W · 2025-09-09T14:23:34Z

Yep, this was a temporary workflow. we usually don't receive this many PR and don't review this fast. Maybe worth rethink it to make a rc to avoid what we encountered yesterday as well

bearomorphism · 2025-09-23T02:57:22Z

commitizen/version_schemes.py

+ (?P<release>[0-9]+(?:\.[0-9]+)*) # release segment
+ (?P<pre> # pre-release
+ [-_\.]?
+ # BEGIN different from packaging.version.py


Added those comments.

bearomorphism requested review from Lee-W, noirbizarre and woile as code owners June 12, 2025 19:14

bearomorphism marked this pull request as draft June 12, 2025 19:14

github-actionsbot added pr-status: wait-for-review type: bug labels Jun 12, 2025

bearomorphism force-pushed the bear-fix-semver-not-fully-covered branch from 0972ba2 to 877fcd6Compare June 12, 2025 19:26

bearomorphism commented Jun 12, 2025
View reviewed changes

bearomorphism force-pushed the bear-fix-semver-not-fully-covered branch from 877fcd6 to da46193Compare June 13, 2025 13:09

bearomorphism changed the title ~~WIP fix semver not fully covered~~fix semver not fully coveredAug 13, 2025

bearomorphism marked this pull request as ready for review August 13, 2025 01:30

Lee-W added this to the 4.9.0 milestone Aug 17, 2025

Lee-W reviewed Aug 24, 2025
View reviewed changes

Lee-W added pr-status: wait-for-response and removed pr-status: wait-for-review labels Aug 24, 2025

Lee-W force-pushed the v4-9-0-test branch from 69db5b4 to b313847Compare August 28, 2025 02:28

bearomorphism force-pushed the bear-fix-semver-not-fully-covered branch from da46193 to 3081fffCompare September 8, 2025 08:34

github-actionsbot added the pr-status: wait-for-review label Sep 8, 2025

Lee-W modified the milestones: 4.9.0, 4.9.1 Sep 9, 2025

Lee-W force-pushed the v4-9-0-test branch from c700d66 to 8b969dbCompare September 9, 2025 05:56

Lee-W deleted the branch commitizen-tools:masterSeptember 9, 2025 06:09

Lee-W closed this Sep 9, 2025

Lee-W reopened this Sep 9, 2025

Lee-W changed the base branch from v4-9-0-test to masterSeptember 9, 2025 14:22

Lee-W removed this from the 4.9.1 milestone Sep 9, 2025

Lee-W added this to the 4.9.2 milestone Sep 9, 2025

test(version_scheme): add test case "1.0.0-reallyweird" to semver
918cfd6

bearomorphism force-pushed the bear-fix-semver-not-fully-covered branch from 3081fff to 8ee1dbeCompare September 13, 2025 03:38

fix(BaseVersion): support more tag format
bb48144

bearomorphism force-pushed the bear-fix-semver-not-fully-covered branch from 8ee1dbe to bb48144Compare September 13, 2025 09:45

bearomorphism commented Sep 23, 2025
View reviewed changes

bearomorphism marked this pull request as draft September 27, 2025 02:13

bearomorphism mentioned this pull request Sep 27, 2025
Improve readability in version scheme tests #1631
Closed

Uh oh!

fix semver not fully covered#1548

Are you sure you want to change the base?

fix semver not fully covered #1548

Uh oh!

Conversation

bearomorphism commented Jun 12, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

bearomorphismJun 12, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecovbot commented Jun 13, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bearomorphism commented Sep 8, 2025

Uh oh!

bearomorphism commented Sep 9, 2025

Uh oh!

Lee-W commented Sep 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bearomorphism commented Jun 12, 2025•
edited
Loading

bearomorphismJun 12, 2025•
edited
Loading

codecovbot commented Jun 13, 2025•
edited
Loading