Skip to content

Conversation

@dulmandakh
Copy link
Contributor

@dulmandakhdulmandakh commented Aug 14, 2024

Description of the Change

Django 5.1 introduced LoginRequiredMiddleware to allow authentication across the site, and this PR adds compatibility with it using login_not_required decorator.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@dulmandakhdulmandakh changed the title compat with LoginRequiredMiddleware and login_not_requiredcompat with LoginRequiredMiddleware middlewareAug 14, 2024
@n2ygkn2ygk modified the milestones: Future, 3.0.0Aug 14, 2024
@n2ygk
Copy link
Contributor

please request a review when ready

@dulmandakh
Copy link
ContributorAuthor

dulmandakh commented Aug 15, 2024

@n2ygk changed tests. Please don't pay attention to CI configuration changes, I'll rebase once #1455 merged.

@n2ygkn2ygk self-requested a review August 15, 2024 13:04
@n2ygk
Copy link
Contributor

@n2ygk changed tests. Please don't pay attention to CI configuration changes, I'll rebase once #1455 merged.

OK #1455 merged to please rebase.

@dulmandakh
Copy link
ContributorAuthor

@n2ygk done, all tests are passing 😉

Copy link
Contributor

@n2ygkn2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@n2ygkn2ygk merged commit 1dcef1b into django-oauth:masterAug 15, 2024
@dulmandakhdulmandakh deleted the login_not_required branch August 15, 2024 14:15
@n2ygkn2ygk mentioned this pull request Aug 15, 2024
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dulmandakh@n2ygk