drop support for Django versions below 4.2#1455
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dulmandakh changed the title 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #1455 +/- ## ========================================== - Coverage 97.34% 97.32% -0.03% ========================================== Files 32 32 Lines 2112 2128 +16 ========================================== + Hits 2056 2071 +15 - Misses 56 57 +1 ☔ View full report in Codecov by Sentry. |
ContributorAuthor
dulmandakh commented Aug 14, 2024
@n2ygk please review and merge. I have no idea why codecov is failing. Let's make CI lean and clean. |
Contributor
n2ygk commented Aug 14, 2024
Yeah codecov keeps misreporting that tiny delta but it's unclear why. Luckily it done's block accepting the PR. |
n2ygkforce-pushed the remove-django-below-4.2 branch from 75c28f8 to 2e2af76Compare
n2ygk requested changes Aug 14, 2024
Contributor
n2ygk left a comment
n2ygk left a comment There was a problem hiding this comment.
Nice work! Thanks for simplifying the workfliws.
One question regarding python 3.8, 3.9 needs to be resolved.
Uh oh!
There was an error while loading. Please reload this page.
5 tasks
n2ygk approved these changes Aug 15, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Django versions below 4.2 are no longer supported, so this PR removes mentions and CI for these versions.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS