This repository was archived by the owner on Mar 4, 2020. It is now read-only.
src: replace SetAccessor w/ SetAccessorProperty#38
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
PR-URL: nodejs/node#17665Fixes: nodejs/node#17636 Refs: nodejs/node#16482 Refs: nodejs/node#16860 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
jasonrudolph commented Jun 14, 2018
Thank you, @ckerr! ⚡🙇 |
Closed
1 task
Contributor
alexeykuzmin commented Jun 14, 2018
@ckerr Is it a clean cherry-pick or you made some changes? |
ckerr changed the title 
Remove reliance on V8-specific error messages in test/parallel/test-tls-external-accessor.js. Check that the error is a `TypeError`. The test should now be successful without modification using ChakraCore. Backport-PR-URL: nodejs/node#20456 PR-URL: nodejs/node#16272 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MemberAuthor
ckerr commented Jun 15, 2018
@alexeykuzmin: @jasonrudolph found the upstream patch that fixes the tests too, nodejs/node@7eba62e I've confirmed that Node's tests pass when I check out v8.9.3 and then cherry-pick nodejs/node@efffcc2 and nodejs/node@7eba62e together |
ckerr changed the title jasonrudolph commented Jun 15, 2018
Including the failing test output here for reference: That failure appears to be resolved by nodejs/node#16272, which was backported to 8.x in nodejs/node#20478 via nodejs/node@7eba62e. I've cherry-picked that commit onto this branch, and that fixes the failing test. |
alexeykuzmin approved these changes Jun 15, 2018
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks nodejs/node@efffcc2 into our
electron-node-v8.9.3branch for use in a future Electron 2.0.x release.Requested by @jasonrudolph as a possible fix for electron/electron#13061 when running tests in headless mode in Atom (atom/atom#17409).