src: make StreamBase prototype accessors more robust

[joyeecheung]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

src

This problem showed up when I was stepping into Writable.prototype.write and hover over this from a console.log call, there was assertion like this:

see assertion

node[90480]: ../src/util-inl.h:243:TypeName *node::Unwrap(v8::Local<v8::Object>) [TypeName = node::LibuvStreamWrap]: Assertion `(object->InternalFieldCount()) > (0)' failed. 1: node::Abort() [/Users/joyee/.tnvm/versions/node/v9.0.0/bin/node] 2: node::(anonymous namespace)::DomainEnter(node::Environment*, v8::Local<v8::Object>) [/Users/joyee/.tnvm/versions/node/v9.0.0/bin/node] 3: node::LibuvStreamWrap::~LibuvStreamWrap() [/Users/joyee/.tnvm/versions/node/v9.0.0/bin/node] 4: void node::StreamBase::GetBytesRead<node::LibuvStreamWrap>(v8::Local<v8::String>, v8::PropertyCallbackInfo<v8::Value> const&) [/Users/joyee/.tnvm/versions/node/v9.0.0/bin/node] 5: v8::internal::PropertyCallbackArguments::Call(void (*)(v8::Local<v8::Name>, v8::PropertyCallbackInfo<v8::Value> const&), v8::internal::Handle<v8::internal::Name>) [/Users/joyee/.tnvm/versions/node/v9.0.0/bin/node] 6: v8::internal::Object::GetPropertyWithAccessor(v8::internal::LookupIterator*) [/Users/joyee/.tnvm/versions/node/v9.0.0/bin/node] 7: v8::internal::JSReceiver::GetOwnPropertyDescriptor(v8::internal::LookupIterator*, v8::internal::PropertyDescriptor*) [/Users/joyee/.tnvm/versions/node/v9.0.0/bin/node] 8: v8::internal::JSReceiver::GetOwnPropertyDescriptor(v8::internal::Isolate*, v8::internal::Handle<v8::internal::JSReceiver>, v8::internal::Handle<v8::internal::Object>, v8::internal::PropertyDescriptor*) [/Users/joyee/.tnvm/versions/node/v9.0.0/bin/node] 9: v8::internal::Builtin_Impl_ObjectGetOwnPropertyDescriptor(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/Users/joyee/.tnvm/versions/node/v9.0.0/bin/node] 10: 0x3f95 

because the inspector would wrap the inspected project's prototype when generating previews. This is also reproducible when util.inspect a prototype setup by StreamBase::AddMethods. This PR makes those accessors nonenumerable and check the signatures in the accessors so they throw instead of raise assertions.

[joyeecheung]

This is not engine-agnostic but I am not sure what ChakraCore throws for this..

[bnoordhuis]

Four space indent here and two lines below.

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/11339/

[joyeecheung]

Landed in 1ee3244, thanks!

[MylesBorins]

I've landed this in both v6.x and v8.x staging

please let me know if this should bake longer before releasing

[jure]

As mentioned in #16949 (comment), isn't there a way to have it not assert, as was the case in 8.8.1 (just return undefined)?

We've been seeing some new test failures with the error thrown here, and the cause is hard to discover (and even harder to fix).