Skip to content

Conversation

@lucamilanesio
Copy link
Contributor

No description provided.

[2.15.7](https://www.gerritcodereview.com/2.15.html#2157),
[2.14.17](https://www.gerritcodereview.com/2.14.html#21417),
[2.15.6](https://www.gerritcodereview.com/2.15.html#2156),
[2.14.16](https://www.gerritcodereview.com/2.14.html#21416)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with that, though we try to list all the recent releases even if they have been obsoleted. But I would suggest removing the comma at the end of the line related to 2.14.17, if you still want to remove the obsolete releases.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with that, though we try to list all the recent releases even if they have been obsoleted.

Sure, the problem is that 2.14.16 and 2.15.6 were completely broken (DB connection leak) and have been then dismissed. Better to remove any reference to them.

But I would suggest removing the comma at the end of the line related to 2.14.17, if you still want to remove the obsolete releases.

Yes, let me do that now. Thanks.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@chriscool
Copy link
Collaborator

Thank you @lucamilanesio for the Gerrit User Summit 2018 report!

@chriscoolchriscool merged commit 8fbdba2 into git:masterNov 19, 2018
@chriscool
Copy link
Collaborator

I made a few improvements on top in 6b9c19f.

@lucamilanesio
Copy link
ContributorAuthor

Thanks a lot.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lucamilanesio@chriscool