Skip to content

Add Gerrit Code Review news#316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chriscool merged 3 commits into from
Nov 19, 2018
Merged

Add Gerrit Code Review news #316

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a26738
Remove obsolete Gerrit releases
lucamilanesio Nov 19, 2018
61981d3
Add Gerrit User Summit 2018 report
lucamilanesio Nov 19, 2018
0187c9e
Remove trailing comma on Gerrit releases
lucamilanesio Nov 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions rev_news/drafts/edition-45.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -123,9 +123,7 @@ This edition covers what happened during the month of October 2018.
[11.4.0](https://about.gitlab.com/2018/10/22/gitlab-11-4-released/)
+ Gerrit Code Review [2.16](https://www.gerritcodereview.com/2.16.html),
[2.15.7](https://www.gerritcodereview.com/2.15.html#2157),
[2.14.17](https://www.gerritcodereview.com/2.14.html#21417),
[2.15.6](https://www.gerritcodereview.com/2.15.html#2156),
[2.14.16](https://www.gerritcodereview.com/2.14.html#21416)
Copy link
Collaborator

@chriscoolchriscoolNov 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with that, though we try to list all the recent releases even if they have been obsoleted. But I would suggest removing the comma at the end of the line related to 2.14.17, if you still want to remove the obsolete releases.

Copy link
ContributorAuthor

@lucamilanesiolucamilanesioNov 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with that, though we try to list all the recent releases even if they have been obsoleted.

Sure, the problem is that 2.14.16 and 2.15.6 were completely broken (DB connection leak) and have been then dismissed. Better to remove any reference to them.

But I would suggest removing the comma at the end of the line related to 2.14.17, if you still want to remove the obsolete releases.

Yes, let me do that now. Thanks.

Copy link
ContributorAuthor

@lucamilanesiolucamilanesioNov 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Collaborator

@chriscoolchriscoolNov 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

[2.14.17](https://www.gerritcodereview.com/2.14.html#21417)
+ GitKraken [4.1.1](https://support.gitkraken.com/release-notes/current),
[4.1.0](https://support.gitkraken.com/release-notes/current)
+ GitHub Desktop [1.5.0](https://desktop.github.com/release-notes/)
Expand All@@ -146,6 +144,13 @@ __Various__
Schindelin will work on improving `git bisect`. GitHub will sponsor
these internships.

* [Gerrit User Summit 2018, Summary Report](https://gitenterprise.me/2018/11/18/gerrit-user-summit-2018-2/)

The Gerrit User Summit 2018 at Cloudera in Palo Alto has ended with over 80+ participants coming
all over the world. Main topics have been the release of Gerrit v2.16, support for Git protocol v2,
Gerrit DevOps Analytics & Insights and the support for Kubernetes.


__Light reading__


Expand Down