Skip to content

chore(electron): Move off deprecated remote module#649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
afonsojramos merged 7 commits into from
Oct 9, 2023
Merged

chore(electron): Move off deprecated remote module #649

afonsojramos merged 7 commits into from
Oct 9, 2023

Conversation

@bmulholland
Copy link
Collaborator

@bmulhollandbmulholland commented Oct 3, 2023•
edited
Loading

This is a requirement for electron v14, which drops the module. We can do it before the upgrade, for smaller changes.

@bmulholland
Copy link
CollaboratorAuthor

bmulholland commented Oct 3, 2023•
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@bmulhollandbmulholland mentioned this pull request Oct 3, 2023
Merged
1 task
@bmulholland
Copy link
CollaboratorAuthor

bmulholland commented Oct 3, 2023

This introduces a new issue, probably on a check for isLinux: [79860:1003/134934.778674:INFO:CONSOLE(2)] "Uncaught TypeError: Cannot read property 'process' of undefined"

@bmulhollandbmulholland marked this pull request as draft October 3, 2023 11:52
@bmulhollandbmulhollandforce-pushed the 10-03-chore_electron_Move_off_deprecated_remote_module branch from a76fa67 to 46d82b4CompareOctober 3, 2023 11:52
@bmulhollandbmulholland marked this pull request as ready for review October 3, 2023 11:57
@bmulholland
Copy link
CollaboratorAuthor

bmulholland commented Oct 3, 2023

Fixed

bmulholland
bmulholland commented Oct 3, 2023
View reviewed changes
@bmulhollandbmulhollandforce-pushed the 10-03-chore_electron_Move_off_deprecated_remote_module branch from 32f92d6 to 81a8748CompareOctober 3, 2023 14:21
@bmulhollandbmulhollandforce-pushed the 10-03-chore_electron_Move_off_deprecated_remote_module branch from 9fbb3a3 to d756682CompareOctober 3, 2023 15:19
This was referenced Oct 4, 2023
Merged
Merged
Merged
Closed
Base automatically changed from renovate/axios-1.x to mainOctober 4, 2023 12:16
@afonsojramosafonsojramos merged commit 4d65077 into mainOct 9, 2023
@afonsojramosafonsojramos deleted the 10-03-chore_electron_Move_off_deprecated_remote_module branch October 9, 2023 23:37
@setchysetchy added the refactor Refactoring of existing feature label Mar 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afonsojramosafonsojramosafonsojramos approved these changes

Assignees

No one assigned

Labels

refactorRefactoring of existing feature

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bmulholland@afonsojramos@setchy