chore: Replace remote for setting auto-open pref#653
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2023
CollaboratorAuthor
bmulholland commented Oct 4, 2023
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
11 tasks
bmulhollandforce-pushed the 10-04-chore_Replace_remote_for_setting_auto-open_pref branch from 369befe to 4a5ffd9CompareCollaboratorAuthor
Coveralls is right, we don't test the code pulled into main.js for IPC communication. Is it worth it, though? The unit test would just mock out the call, so I'm not really sure what value it would provide -- what's the test actually testing? |
Base automatically changed from 10-04-chore_Replace_remote_for_hiding_window to mainOctober 10, 2023 00:16
bmulhollandforce-pushed the 10-04-chore_Replace_remote_for_setting_auto-open_pref branch from 4a5ffd9 to f0ec1ccComparebmulhollandforce-pushed the 10-04-chore_Replace_remote_for_setting_auto-open_pref branch from f0ec1cc to 0fc4a21Compare
afonsojramos approved these changes Oct 18, 2023
afonsojramos deleted the 10-04-chore_Replace_remote_for_setting_auto-open_pref branch 
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the last usages of remote, which generally isn't recommended