feat: implement showNotificationsCountInTray setting

[adufr]

Related issues

#750

Context

Introduce a new setting (disabled by default), that uses the tray.setTitle() API to show the notifications count next to the tray icon.

Discussion

There are quite a lot of changes because I had to pass settings into a few methods so that the updateTrayIcon() method could inherit them, as it now requires them.

It's also quite the mess in the ipcMain.on('update-icon') event handler, as I had to make sure the icon was refreshed whenever you enable/disable the setting, without losing the notifications count, which is not passed to the function it's not in the scope. (That's why props of updateTrayIcon() are optional)

If you have suggestions to make the implementation easier, please let me know.

I tried implementing some tests, I wanted to use the tray.getTitle() method to add more, but it looks like there's nowhere I could access the tray in the tests...

[adufr]

Hello @setchy, sorry for tagging you but this PR has been here for 45 days and didn't receive a single comment 😢

I think this could be a really great addition to Gitify ; please let me know what you think!

[setchy]

I'll take a look during the week @adufr - we have been quite preoccupied with getting v5 out.

[adufr]

I'll take a look during the week @adufr - we have been quite preoccupied with getting v5 out.

Yeah I can imagine, congrats on that! You've done quite some work and the app looks much better now! 😁

[setchy]

On initial glance, it seems like a lot of files have changes. Is there a simpler path here to access the settings?

[adufr]

@setchy I agree, but I didn't find any other way to make it work 😕

[adufr]

I fixed all conflicts following 5.1.0 release

[setchy]

Thanks @adufr - will take a look once #941 is merged

[adufr]

Do not hesitate to ping me once it's merged, I can probably rewrite the feature

[setchy]

@adufr - with #941 merged, I took a look at this feature - see #945 (didn't want to disrupt your branch).

Functionally, it seems to match. Appreciate you taking a look. I've noted a few of the to-dos on the PR

[adufr]

superseded by #945