feat(settings): show notification count in tray#945
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
adufr reviewed Apr 2, 2024
Contributor
adufr left a comment
adufr left a comment There was a problem hiding this comment.
Tested, lgtm 👍 It's indeed much cleaner now
MemberAuthor
setchy commented Apr 2, 2024
Just need a solution to the Settings UI layout/scrolling then we're good to go |
MemberAuthor
setchy commented Apr 2, 2024
Reworked the Settings screen within #947 |
afonsojramos approved these changes Apr 2, 2024
MemberAuthor
setchy commented Apr 16, 2024
@adufr - shout out, I'm really enjoying this feature. It's nice seeing at a glance just how "green" my notifications backlog is 👏 |
Contributor
adufr commented Apr 16, 2024
Only made possible thanks to you ;) |
Collaborator
bmulholland commented Apr 17, 2024
Yeah actually I was opposed to this at first, but now I use it quite a bit 😅. Thank you! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#750
To do list