fix: missing icon colors on first load

[adufr]

Related issues

• FixesOn first load, notification icons are missing colors #786

Context

Show notification icons colors on app first load / app refresh.

Discussion

I've identified 2 possible fixes:

• First one would be to simply drop this code so that we fetch the state of each notifications, even though settings.colors is falsy.
  

  gitify/src/hooks/useNotifications.ts

  Lines 107 to 117 in 1c3c248

  	if(!colors){
  	setNotifications(data);
  	triggerNativeNotifications(
  	notifications,
  	data,
  	settings,
  	accounts,
  	);
  	setIsFetching(false);
  	return;
  	}

  
  Since notification.state is, for now, only required to load the icons colors, this would result on making a lot of unnecessary api calls if the setting is disabled.

• Second one is the one I've implemented: init settings.colors to null and explicitely check for settings.colors === false, thus fixing the bug AND avoiding making unnecessary api calls

[bmulholland]

I worry that, without comments or tests that explain the behaviour, this will be broken again in a future refactor. How can we protect against that?