Skip to content

fix: missing icon colors on first load#787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
setchy merged 1 commit into from
Feb 18, 2024
Merged

fix: missing icon colors on first load #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/context/App.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -290,7 +290,7 @@ describe('context/App.tsx', () =>{
participating: true,
playSound: true,
showNotifications: true,
colors: false,
colors: null,
markAsDoneOnOpen: false,
},
);
Expand DownExpand Up@@ -328,7 +328,7 @@ describe('context/App.tsx', () =>{
participating: false,
playSound: true,
showNotifications: true,
colors: false,
colors: null,
markAsDoneOnOpen: false,
},
);
Expand Down
2 changes: 1 addition & 1 deletion src/context/App.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,7 @@ export const defaultSettings: SettingsState ={
showNotifications: true,
openAtStartup: false,
appearance: Appearance.SYSTEM,
colors: false,
colors: null,
markAsDoneOnOpen: false,
};

Expand Down
2 changes: 1 addition & 1 deletion src/hooks/useNotifications.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -104,7 +104,7 @@ export const useNotifications = (colors: boolean): NotificationsState =>{
]
: [...enterpriseNotifications];

if (!colors){
if (colors === false){
setNotifications(data);
triggerNativeNotifications(
notifications,
Expand Down
2 changes: 1 addition & 1 deletion src/types.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ export interface SettingsState{
showNotifications: boolean;
openAtStartup: boolean;
appearance: Appearance;
colors: boolean;
colors: boolean | null;
markAsDoneOnOpen: boolean;
}

Expand Down