cleanups,fixes & docs in Bus.__new__() and util.load_config()#309
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
felixdivo requested review from christiansandberg and hardbyte and removed request for hardbyte
CollaboratorAuthor
felixdivo commented May 20, 2018
This is done, but we should write some unit tests before merging this PR to later prevent regression. Note: Making |
hardbyte approved these changes May 27, 2018
Owner
hardbyte left a comment
hardbyte left a comment There was a problem hiding this comment.
Looks good to me. Just two debugging print statements to remove.
can/interface.py Outdated
| # the channel attribute should be present in **config | ||
| print("DEBUGGING: ", args) | ||
| print("DEBUGGING: ", config) |
Owner
There was a problem hiding this comment.
Remove these (or convert to debug level logs)
CollaboratorAuthor
There was a problem hiding this comment.
Ah sure, must've forgotten them there.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
util.load_config()to pass through any unused parameters. It is made more clear in the code whatBus.__new__()is doing and what not. A lot has moved toutil.load_config()to remove code and responsibility duplication. The documentation has each been changed to reflect what the methods are actually doing, that was not done correct before.Based an @randycoulman's comment over here
Fixes#280