2.1.11#401
Merged
2.1.11 #401
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
weakish reviewed May 13, 2019
| raise LeanCloudError(1, "the file is not sucessfully destroyed") | ||
| def _save_to_qiniu_internal_py3(self, token, key): | ||
| from qiniu.services.storage.uploader import crc32, _form_put, put_data |
Contributor
There was a problem hiding this comment.
_save_to_qiniu_internal_py3 看上去没用到 put_data，可以不用 import ？
| final_data = tmp_data | ||
| else: | ||
| final_data += tmp_data | ||
| else: |
Contributor
There was a problem hiding this comment.
这个 else 语句可以直接去掉？因为循环的条件是 while True
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.