Skip to content

Target .NET Standard 1.3#1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ethomson merged 143 commits into from
Jun 24, 2017
Merged

Target .NET Standard 1.3 #1318

ethomson merged 143 commits into from
Jun 24, 2017

Conversation

@AArnott
Copy link
Contributor

@AArnottAArnott commented May 8, 2016•
edited
Loading

Adds .NET Core support (by way of targeting .NET Standard 1.3). .NET Framework 4.0 is still a target, but we
leverage VS2017 .NET SDK projects to multi-target both net40 and netstandard1.3 to maximize reach and enable libgit2sharp to work across platforms by way of .NET Core.

Closes#1293

AArnott added 30 commits March 29, 2016 08:46
@AArnott
Move most source into a Shared Project
442f626
This is in preparation for a portable project alongside the net40 one.
@AArnott
Add portable project
d7ef5f3
Plenty of compiler errors at this point.
@AArnott
Fix default namespace in portable project
68ee9b7
@AArnott
Consistently apply NET40 compiler constant to all configs
e08f9e5
Before this, it only existed in debug configuration.
@AArnott
Suppress serializable exceptions for portable
ef51bef
RecurseSubmodulesException claimed to be serializable but was missing a deserializing constructor so I added that.
@AArnott
Fix build break in test project
61176b8
@AArnott
Add #if around ReliabilityContractAttribute
6704b7d
@AArnott
Fix some reflection code for portable
b6aa86d
@AArnott
Fix GetType() instance invocations
2e32bb0
@AArnott
Fix build warnings and remove project.lock.json
4cc6acd
@AArnott
Use Nerdbank.GitVersioning
6a2fb6b
This will keep the maintenance cost of updating the version to just one file (one line, in fact) instead of the 3 lines it was before, and the dozens of lines it would become with the increase in number of projects that may occur in the near future.
@AArnott
Add code generation functionality
e94a7b2
@AArnott
Activate code generation for many methods
9067041
@AArnott
Apply code generator to more signatures
3c8ab4b
@AArnott
Replace CustomMarshaler use on return values and out parameters
370cdfa
@AArnott
Get code generation working in portable project
2557d8c
@AArnott
Add X509Certificates reference
9abdff2
@AArnott
Fix a couple minor compile breaks in portable
250599c
@AArnott
Fix decoding compiler breaks
a4a2383
@AArnott
Merge remote-tracking branch 'upstream/master' into portable
476e4be
@AArnott
Fix a couple new compiler errors in portable
da5e55c
@AArnott
Avoid Trace and Console use in portable
bf7ad91
@AArnott
Add SecureString type
e7d9457
@AArnott
Skipping initializing nativeLibraryPath on portable
5d58dfa
@AArnott
Add portable BufferedStream
7971833
@AArnott
Fix compile error around exporting SecureString
12253be
@AArnott
Avoid CriticalFinalizerObject on portable
41ee5d3
@AArnott
Portable project builds!
fe10951
@AArnott
Merge upstream/master into portable
aceef06
And fix up build breaks it introduces
@AArnott
Enable tracing on portable
0bae5e3
@AArnott
Copy link
ContributorAuthor

AArnott commented May 1, 2017

Yes, that makes sense.
nit: I would leave analyzers in PrivateAssets as well, since if analyzers were ever added to the nativebinaries package, it wouldn't be meant to be consumed by libgit2sharp consumers.

@bording
Copy link
Member

bording commented May 1, 2017

nit: I would leave analyzers in PrivateAssets as well, since if analyzers were ever added to the nativebinaries package, it wouldn't be meant to be consumed by libgit2sharp consumers.

So my thought process on this was, since we don't have any analyzers in the native binaries package, there wouldn't be any harm dropping that from the list. I can't currently think of a scenario where we'd add an analyzer, but if we did, who's to say if it would be just for LibGit2Sharp, or all consumers?

Ultimately, regardless of which option we choose, there's a chance it would have to be revisited should the native binaries package actually add an analyzer, so it made sense to me to only include things in the list that we know for sure we don't want downstream consumers to see.

@AArnott
Copy link
ContributorAuthor

AArnott commented May 1, 2017

That's fine. It was just a nit anyway, and my motivation for it was to maintain the default nuget include/exclude behaviors unless we had an explicit reason to do otherwise.

@AArnott
Copy link
ContributorAuthor

AArnott commented May 6, 2017

@bording and @ethomson you're not waiting on me, right? I think we're waiting on your review of the PR?
It would be great to get this in, of course. :)

@bording
Copy link
Member

bording commented May 7, 2017

@AArnott No, not waiting on you. I do want to take one more look over this now that all the feedback has been incorporated, but I believe the main thing we're waiting on is that @ethomson wants to get out one more release before we merge this in.

@ethomson
Copy link
Member

ethomson commented May 7, 2017

I'd like to do a release but we're waiting on finalizing some things in libgit2. I'm going to branch for the upcoming release so that we can merge this into master.

This was referenced May 20, 2017
Closed
Merged
@Alxandr
Copy link

Alxandr commented May 30, 2017

@ethomson Do you have a link to any issue on things being finalized in libgit2?

@stephenwilliams
Copy link

stephenwilliams commented Jun 15, 2017

Is there any indication when this will be available?

@ethomson
Copy link
Member

ethomson commented Jun 21, 2017

Okay - v0.24 is released based on libgit2 v0.26. Thanks for your patience.

@AArnott would you mind a final update just to fix the merge conflicts (which I think should be minor, but if not, then please let me know and I'm happy to resolve them), and rev the version number, and then we'll merge this?

@AArnott
Copy link
ContributorAuthor

AArnott commented Jun 21, 2017

with pleasure...

@AArnottAArnott changed the title Add a portable library version (for CoreCLR support)Target .NET Standard 1.3Jun 21, 2017
@AArnott
Copy link
ContributorAuthor

AArnott commented Jun 21, 2017

Validation complete.

@ethomsonethomson merged commit c72b740 into libgit2:masterJun 24, 2017
@ethomson
Copy link
Member

ethomson commented Jun 24, 2017

Thanks @AArnott, @bording and everybody for your hard work and infinite patience! This is amazing! 🎉

@ethomson
Copy link
Member

ethomson commented Jun 24, 2017

image

@ethomson
Copy link
Member

ethomson commented Jun 24, 2017

giphy

@ethomson
Copy link
Member

ethomson commented Jun 24, 2017

giphy 1

@AArnottAArnott deleted the portable branch June 24, 2017 13:44
@connieyconniey mentioned this pull request Jul 2, 2017
Merged
@jaredcnance
Copy link

jaredcnance commented Jul 10, 2017

This is great and thanks for your work. Any idea when 0.25 will be available on NuGet?

@bording
Copy link
Member

bording commented Jul 10, 2017

@jaredcnance No specific ETA yet, but hoping to have available "Soon".

@kzukzu mentioned this pull request Jul 27, 2017
Closed
@HebaruSanHebaruSan mentioned this pull request Sep 11, 2017
Open
@firelizzard18firelizzard18 mentioned this pull request Jan 25, 2018
Closed
@Cyberboss
Copy link

Cyberboss commented Jan 30, 2018

(tm)

@ethomsonethomson mentioned this pull request Feb 17, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bordingbordingbording left review comments

@ethomsonethomsonethomson left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@AArnott@ethomson@shiftkey@ah-@devlead@bording@ctaggart@danwalmsley@Alxandr@stephenwilliams@jaredcnance@Cyberboss