Target .NET Standard 1.3#1318
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -36,10 +36,5 @@ _ReSharper*/ | ||
| *.userprefs | ||
| *.swp | ||
| *.DotSettings | ||
| _NCrunch_LibGit2Sharp/ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <ProjectSdk="Microsoft.NET.Sdk"> | ||
Member There was a problem hiding this comment. While the workaround to get this working properly was to commit the assembly directly vs building it, would it be worth including in the VS solution so it shows up at least? Also, why is the folder where the assembly is saved called ContributorAuthor There was a problem hiding this comment. If it's in the solution file, it will build (unless I do rather unusual things that will likely confuse folks). And if I leave it building, folks will expect that is meaningful for something in the product, and it isn't. Also, if it's in the solution, then package restore has to bring down more packages as this project has unique ones. So it will slow down package restore and builds on CIs and dev machines with no value. As it stands alone, it can be built as a lone project without an sln. So in the rare event we may actually need to update the code gen project, we can still do that -- and possibly add it to its own temporary solution at that time. lkg = Last Known Good. In my work experience lkg is used to refer to a checked in toolset, which is exactly what this is. We build the toolset (or at least this small part of it), then we check it in so we can use it next time without building it first. If we were to update the toolset, we'd test it, then we'd check it in as the 'last known good' version has updated. I'm not passionate about the name. I'm happy to rename it if you'd prefer something else. Member There was a problem hiding this comment.
That makes sense. No reason to add it, then.
I don't recall ever coming across that acronym before, so thanks for the explanation. I can't immediately think of something else I'd prefer, so seems OK to stick with | ||
| <PropertyGroup> | ||
| <TargetFramework>netstandard1.5</TargetFramework> | ||
| <PackageTargetFallback>$(PackageTargetFallback);portable-net45+win8+wp8+wpa81;</PackageTargetFallback> | ||
| <IsPackable>false</IsPackable> | ||
| <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageReferenceInclude="CodeGeneration.Roslyn"Version="$(CodeGenerationRoslynVersion)" /> | ||
| </ItemGroup> | ||
| </Project> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFrameworks>net40;netstandard1.0</TargetFrameworks> | ||
| <SignAssembly>true</SignAssembly> | ||
| <AssemblyOriginatorKeyFile>..\libgit2sharp.snk</AssemblyOriginatorKeyFile> | ||
| <IsPackable>false</IsPackable> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="CodeGeneration.Roslyn.Attributes" Version="$(CodeGenerationRoslynVersion)" /> | ||
| </ItemGroup> | ||
| </Project> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Diagnostics; | ||
| using System.Text; | ||
| namespace LibGit2Sharp | ||
| { | ||
| [AttributeUsage(AttributeTargets.Parameter | AttributeTargets.ReturnValue, AllowMultiple = false)] | ||
| [Conditional("CodeGeneration")] | ||
| public class CustomMarshalerAttribute : Attribute | ||
| { | ||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="CustomMarshalerAttribute"/> class. | ||
| /// </summary> | ||
| /// <param name="customMarshaler">The type that derives from ICustomMarshaler.</param> | ||
| /// <param name="friendlyType">The type to expose in the generated overload.</param> | ||
| public CustomMarshalerAttribute(Type customMarshaler, Type friendlyType) | ||
| { | ||
| } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| using System; | ||
| using System.Diagnostics; | ||
| using CodeGeneration.Roslyn; | ||
| namespace LibGit2Sharp | ||
| { | ||
| /// <summary> | ||
| /// Causes generation of an overload of a P/Invoke method that has a more friendly signature. | ||
| /// </summary> | ||
| [AttributeUsage(AttributeTargets.Class, AllowMultiple = true)] | ||
| [CodeGenerationAttribute("CodeGeneration.OfferFriendlyInteropOverloadsGenerator, CodeGeneration, Version=" + ThisAssembly.AssemblyVersion + ", Culture=neutral, PublicKeyToken=null")] | ||
| [Conditional("CodeGeneration")] | ||
| public class OfferFriendlyInteropOverloadsAttribute : Attribute | ||
| { | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <Project> | ||
| <PropertyGroup> | ||
| <OutputPath>$(MSBuildThisFileDirectory)bin\$(MSBuildProjectName)\$(Configuration)\</OutputPath> | ||
| <BaseIntermediateOutputPath>$(MSBuildThisFileDirectory)obj\$(MSBuildProjectName)\</BaseIntermediateOutputPath> | ||
| <CodeGenerationRoslynVersion>0.3.13-gfce1c8ba1e</CodeGenerationRoslynVersion> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="Nerdbank.GitVersioning" Version="1.6.25" PrivateAssets="all" /> | ||
| </ItemGroup> | ||
| </Project> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <Project> | ||
| <PropertyGroup> | ||
| <PublicSign Condition=" '$(AssemblyOriginatorKeyFile)' != '' and '$(OS)' != 'Windows_NT' ">true</PublicSign> | ||
| </PropertyGroup> | ||
| </Project> |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we doing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the git "height" can be calculated during the build, as it makes up part of the version number of the nuget package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, that's clever.
Apparently Travis doesn't have an option to just do a regular clone, which is a pity, since a shallow clone followed by unshallowing it is crazy expensive compared to just doing a regular clone in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I couldn't find a way to disable their shallow fetching, so this seemed like the best workaround.