- Notifications
You must be signed in to change notification settings - Fork 452
Linux Hotplug: Connection-callback implementation for hidraw#647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux Hotplug: Connection-callback implementation for hidraw #647
Uh oh!
There was an error while loading. Please reload this page.
Conversation
bb974de to 436b902CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HIDAPI uses tabs for indentation
if you've noticed otherwise - thet's a "bug"
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Youw left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my comments are only about code-style for now
I really need to find time to review this (and others) thoroughly
9d5720e to 43956beComparek1-801 commented Nov 23, 2023
Did some adjustents to the code-style (in fact, got my IDE set up to keep track of it). |
2bf0493 to 1008a83CompareUh oh!
There was an error while loading. Please reload this page.
mcuee commented Mar 6, 2024
Not so sure how to re-run the github actions as there were build error previously. |
mcuee commented Mar 6, 2024
I will test this under Linux later. |
mcuee commented Mar 8, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
This seems to work fine under Ubuntu Linux 20.04. Unplug and plug of a USB mouse receiver Unplug and plug of USBasp programmer (USB Composite device) Unplug and plug of Plantronics Headset (USB composite device) DetailsMore detailed output using sudo. |
fc3491c to 7830967Comparemcuee commented Mar 12, 2024
Test of latest commit under Ubuntu Linux 20.04
Details |
k1-801 commented Mar 12, 2024
Noticed a very minor issue with this PR - the code lacks a |
k1-801 commented Mar 12, 2024
Fixed the cleanup procedure. Doesn't affect how the events themselves work. |
mcuee commented Mar 12, 2024
Last git commit is still working fine. Thanks. Tested under Ubuntu Linux 20.04. Unplug and plug of Platronics USB headset Details |
Youw left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same deal as with #645 - getting it merged into a feature branch now.
No description provided.