Connection callback: merged feature for all platforms#667
+1,918 −144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…back (libusb#299) - initial API; - Windows backend implementation;
- fix merge conflict - fix indentation in a few places
Member
mcuee commented Mar 13, 2024
Nice. Just carry out a test under Windows 11 and there are no issues. Details |
Author
k1-801 commented Mar 28, 2024
Forwarded the reviewed changes from #646 here as well |
Author
k1-801 commented Apr 6, 2024
Converted to draft to cherry-pick all changes from #646 that were made before merge |
Member
Youw commented Apr 6, 2024
Closing if favor of #674 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR incorporates changes #299, #645, #646, #647, #653, and #668 to be merged into
masteras one pull-request.Implements the Hotplug feature for Windows, Linux, MacOS, and for the libusb backend. Of the currently supported backends the only one with no implementation is netbsd.
Resolves#238
Resolves#538
At this moment the project: https://gitlab.com/CalcProgrammer1/OpenRGB/-/merge_requests/1963 is waiting for this feature to be released in hidapi.