fix: change event types from MouseEvent to PointerEvent#2016
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
Bashamega commented May 9, 2025
What do you think @saschanaz |
1 similar comment
Bashamega commented May 13, 2025
What do you think @saschanaz |
saschanaz left a comment
saschanaz left a comment There was a problem hiding this comment.
Apparently I did not submit the comment...
| }, | ||
| { | ||
| "name": "contextmenu", | ||
| "type": "MouseEvent" |
There was a problem hiding this comment.
This and auxclick should also be PointerEvent. https://w3c.github.io/pointerevents/#the-click-auxclick-and-contextmenu-events
There was a problem hiding this comment.
Hmmmmm actually contextmenu and auxclick already has PointerEvent? 🤔 In that case we can remove contextmenu and auxclick here.
There was a problem hiding this comment.
Actually, no, they were being overwritten in the overridingTypes, I have just removed them from there.
saschanaz commented May 14, 2025
LGTM |
There was an issue merging, maybe try again saschanaz. Details |
saschanaz commented May 14, 2025
LGTM |
github-actionsbot merged commit 043b1d8 into microsoft:mainUh oh!
There was an error while loading. Please reload this page.
Merging because @saschanaz is a code-owner of all the changes - thanks! |
3 participants
I have converted MouseEvent to PointerEvent in some occurrences.
References:
1- https://w3c.github.io/uievents/#event-type-click
2 - https://caniuse.com/?search=PointerEvent
3 - https://developer.mozilla.org/en-US/docs/Web/API/Element/click_event
Solves:
1- microsoft/TypeScript#60746
2 - microsoft/TypeScript#61647 (comment)