- Notifications
You must be signed in to change notification settings - Fork 13.2k
DOM Update 2025-05-02#61647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOM Update 2025-05-02 #61647
Uh oh!
There was an error while loading. Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the DOM types to incorporate changes from the referenced TypeScript-DOM-lib-generator pull request, while ensuring that related error messages and contextual type instantiations continue to behave as expected.
- Updates baseline errors for instantiateContextualTypes tests
- Covers new contextual typing scenarios with generic components and reducer patterns
Files not reviewed (6)
- tests/baselines/reference/collisionThisExpressionAndLocalVarInLambda.types: Language not supported
- tests/baselines/reference/globalThisBlockscopedProperties.types: Language not supported
- tests/baselines/reference/instantiateContextualTypes.types: Language not supported
- tests/baselines/reference/noCollisionThisExpressionAndLocalVarInLambda.types: Language not supported
- tests/baselines/reference/underscoreTest1.types: Language not supported
- tests/baselines/reference/unicodeIdentifierName2.types: Language not supported
rbuckton commented May 2, 2025
@typescript-bot test this |
typescript-bot commented May 2, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
typescript-bot commented May 2, 2025
Hey @rbuckton, the results of running the DT tests are ready. There were interesting changes: Branch only errors:Package: jquery.fancytree Package: w3c-image-capture Package: summernote Package: node Package: ckeditor4 Package: dropboxjs Package: microsoft-ajax Package: photoswipe Package: hashset Package: codemirror Package: signals Package: chrome Package: react-swipe Package: snapsvg Package: jquery/v1 Package: jquery/v2 Package: jquery Package: jquery-touchswipe Package: phonegap Package: three Package: less Package: lscache Package: switchery |
typescript-bot commented May 2, 2025
@rbuckton Here are the results of running the user tests with tsc comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
typescript-bot commented May 2, 2025
@rbuckton Here they are:tscComparison Report - baseline..pr
System info unknown Hosts
Scenarios
Developer Information: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
rbuckton commented May 2, 2025
A large number of failures seem to be due to the signature of |
typescript-bot commented May 2, 2025
@rbuckton Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
jakebailey commented May 2, 2025
|
rbuckton commented May 2, 2025
@typescript-bot run dt |
typescript-bot commented May 2, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Starting jobs; this comment will be updated as builds start and complete.
|
rbuckton commented May 2, 2025
@typescript-bot run dt |
typescript-bot commented May 2, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
saschanaz commented May 2, 2025
Any idea what the failure looks like? |
saschanaz commented May 2, 2025
Err, okay, |
saschanaz commented May 2, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
|
saschanaz commented May 2, 2025
Actually I'm talking about https://github.com/microsoft/TypeScript/actions/runs/14803024546/job/41565917783?pr=61647, but that's just an internal test? |
typescript-bot commented May 2, 2025
Hey @rbuckton, the results of running the DT tests are ready. There were interesting changes: Branch only errors:Package: w3c-image-capture Package: node Package: three |
sandersn left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides ArrayBufferLike, it's almost all additions. Plus tonnes of comment changes.
saschanaz commented May 5, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
|
rbuckton commented May 5, 2025
|
saschanaz commented May 5, 2025
Ah, the "is not assignable to parameter of type 'string'" errors. Err, still looks like something TS test specific, but perhaps also maybe an early smoke of something bigger. I'm open to backout. |
rbuckton commented May 5, 2025
There are similar errors in the user tests, though not as frequent. |
rbuckton commented May 5, 2025
@typescript-bot run dt |
typescript-bot commented May 5, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
typescript-bot commented May 5, 2025
@rbuckton Here are the results of running the user tests with tsc comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
typescript-bot commented May 5, 2025
Hey @rbuckton, the results of running the DT tests are ready. Everything looks the same! |
typescript-bot commented May 6, 2025
@rbuckton Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
rbuckton commented May 7, 2025
@typescript-bot: pack this |
jakebailey commented May 7, 2025
The bot is broken, I am fixing it. (your command also has a colon after the username which probably wouldn't work) |
rbuckton commented May 7, 2025
I have that as a "Saved Reply" on GitHub. It's always worked in the past. |
rbuckton commented May 7, 2025
The errors in |
jakebailey commented May 7, 2025
Oh right, I forgot I made that work in microsoft/typescript-bot-test-triggerer@bb85856 |
rbuckton commented May 7, 2025
I've also put a PR up for VSCode here: microsoft/vscode#248346 |
jakebailey commented May 7, 2025
Should we revert that |
rbuckton commented May 7, 2025
No, the revert we made here was also made to TypeScript-DOM-lib-generator: microsoft/TypeScript-DOM-lib-generator#2015 |
jakebailey commented May 7, 2025
Ah, great; I just hadn't gotten that far into my inbox. |
8c62e08 into mainUh oh!
There was an error while loading. Please reload this page.
This updates the DOM types to include changes from microsoft/TypeScript-DOM-lib-generator#1944, among others.
Fixes#61480