Skip to content

Conversation

@rbuckton
Copy link
Contributor

This updates the DOM types to include changes from microsoft/TypeScript-DOM-lib-generator#1944, among others.

Fixes#61480

@rbucktonrbuckton requested review from Copilot and sandersnMay 2, 2025 18:46
@github-project-automationgithub-project-automationbot moved this to Not started in PR BacklogMay 2, 2025
@typescript-bottypescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 2, 2025
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the DOM types to incorporate changes from the referenced TypeScript-DOM-lib-generator pull request, while ensuring that related error messages and contextual type instantiations continue to behave as expected.

  • Updates baseline errors for instantiateContextualTypes tests
  • Covers new contextual typing scenarios with generic components and reducer patterns
Files not reviewed (6)
  • tests/baselines/reference/collisionThisExpressionAndLocalVarInLambda.types: Language not supported
  • tests/baselines/reference/globalThisBlockscopedProperties.types: Language not supported
  • tests/baselines/reference/instantiateContextualTypes.types: Language not supported
  • tests/baselines/reference/noCollisionThisExpressionAndLocalVarInLambda.types: Language not supported
  • tests/baselines/reference/underscoreTest1.types: Language not supported
  • tests/baselines/reference/unicodeIdentifierName2.types: Language not supported

@rbuckton
Copy link
ContributorAuthor

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 2, 2025

Starting jobs; this comment will be updated as builds start and complete.

CommandStatusResults
test top400✅ Started👀 Results
user test this✅ Started👀 Results
run dt✅ Started👀 Results
perf test this faster✅ Started👀 Results

@typescript-bot
Copy link
Collaborator

Hey @rbuckton, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: jquery.fancytree
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/jquery.fancytree/jquery.fancytree-tests.ts 74:7 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 1 problem (1 error, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: w3c-image-capture
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/w3c-image-capture/index.d.ts 3:15 error TypeScript@local compile error: Duplicate identifier 'ImageCapture' @definitelytyped/expect 18:14 error TypeScript@local compile error: All declarations of 'redEyeReduction' must have identical modifiers @definitelytyped/expect 18:14 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'redEyeReduction' must be of type 'RedEyeReduction | undefined', but here has type 'RedEyeReduction' @definitelytyped/expect 19:14 error TypeScript@local compile error: All declarations of 'imageHeight' must have identical modifiers @definitelytyped/expect 19:14 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'imageHeight' must be of type 'MediaSettingsRange | undefined', but here has type 'MediaSettingsRange' @definitelytyped/expect 20:14 error TypeScript@local compile error: All declarations of 'imageWidth' must have identical modifiers @definitelytyped/expect 20:14 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'imageWidth' must be of type 'MediaSettingsRange | undefined', but here has type 'MediaSettingsRange' @definitelytyped/expect 21:14 error TypeScript@local compile error: All declarations of 'fillLightMode' must have identical modifiers @definitelytyped/expect 21:14 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'fillLightMode' must be of type 'FillLightMode[] | undefined', but here has type 'FillLightMode[]' @definitelytyped/expect 32:14 error TypeScript@local compile error: All declarations of 'max' must have identical modifiers @definitelytyped/expect 32:14 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'max' must be of type 'number | undefined', but here has type 'number' @definitelytyped/expect 33:14 error TypeScript@local compile error: All declarations of 'min' must have identical modifiers @definitelytyped/expect 33:14 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'min' must be of type 'number | undefined', but here has type 'number' @definitelytyped/expect 34:14 error TypeScript@local compile error: All declarations of 'step' must have identical modifiers @definitelytyped/expect 34:14 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'step' must be of type 'number | undefined', but here has type 'number' @definitelytyped/expect 37:6 error TypeScript@local compile error: Duplicate identifier 'RedEyeReduction' @definitelytyped/expect 38:6 error TypeScript@local compile error: Duplicate identifier 'FillLightMode' @definitelytyped/expect 88:5 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'whiteBalanceMode' must be of type 'string | undefined', but here has type 'MeteringMode | undefined' @definitelytyped/expect /mnt/vss/_work/1/DefinitelyTyped/types/w3c-image-capture/w3c-image-capture-tests.ts 24:29 error TypeScript@local compile error: Object is possibly 'undefined' @definitelytyped/expect 25:29 error TypeScript@local compile error: Object is possibly 'undefined' @definitelytyped/expect 26:30 error TypeScript@local compile error: Object is possibly 'undefined' @definitelytyped/expect 68:26 error TypeScript@local compile error: Property 'grabFrame' does not exist on type 'ImageCapture' @definitelytyped/expect 70:24 error TypeScript@local compile error: Parameter 'err' implicitly has an 'any' type @definitelytyped/expect 103:22 error TypeScript@local compile error: Property 'grabFrame' does not exist on type 'ImageCapture' @definitelytyped/expect 105:20 error TypeScript@local compile error: Parameter 'err' implicitly has an 'any' type @definitelytyped/expect 158:21 error TypeScript@local compile error: 'capabilities.focusDistance.min' is possibly 'undefined' @definitelytyped/expect 159:21 error TypeScript@local compile error: 'capabilities.focusDistance.max' is possibly 'undefined' @definitelytyped/expect 160:22 error TypeScript@local compile error: 'capabilities.focusDistance.step' is possibly 'undefined' @definitelytyped/expect ✖ 28 problems (28 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: summernote
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/summernote/summernote-tests.ts 36:7 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 1 problem (1 error, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: node
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/node/test/globals-dom.ts 63:5 error TypeScript@local tsconfig.dom.json, local tsconfig.webworker.json expected type to be: ReadableStream<Uint8Array> || ReadableStream<Uint8Array<ArrayBufferLike>> got: ReadableStream<Uint8Array<ArrayBuffer>> @definitelytyped/expect 64:5 error TypeScript@local tsconfig.dom.json, local tsconfig.webworker.json expected type to be: ReadableStream<any> || ReadableStream<Uint8Array<ArrayBufferLike>> got: ReadableStream<Uint8Array<ArrayBuffer>> @definitelytyped/expect 65:5 error TypeScript@local tsconfig.dom.json, local tsconfig.webworker.json expected type to be: ReadableStream<any> || ReadableStream<Uint8Array<ArrayBufferLike>> got: ReadableStream<Uint8Array<ArrayBuffer>> @definitelytyped/expect ✖ 3 problems (3 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: ckeditor4
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/ckeditor4/ckeditor4-tests.ts 20:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 115:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 134:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 139:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 142:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 143:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 145:11 error TypeScript@local compile error: Argument of type 'unknown' is not assignable to parameter of type 'string | undefined' @definitelytyped/expect 146:11 error TypeScript@local compile error: Argument of type 'unknown' is not assignable to parameter of type 'string | undefined' @definitelytyped/expect 158:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 192:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 194:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 195:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 197:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 198:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 199:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 200:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 201:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 227:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 257:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 258:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 259:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 260:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 264:15 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 265:15 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 286:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 298:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 325:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 335:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 337:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 340:11 error TypeScript@local compile error: Argument of type '{[key: string]: unknown}' is not assignable to parameter of type 'string' @definitelytyped/expect 342:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 344:11 error TypeScript@local compile error: Argument of type 'document' is not assignable to parameter of type 'string' @definitelytyped/expect 346:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 439:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 440:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 442:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 443:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 37 problems (37 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: dropboxjs
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/dropboxjs/dropboxjs-tests.ts 16:19 error TypeScript@local compile error: Argument of type 'ApiError' is not assignable to parameter of type 'string' @definitelytyped/expect 24:19 error TypeScript@local compile error: Argument of type 'ApiError' is not assignable to parameter of type 'string' @definitelytyped/expect 32:19 error TypeScript@local compile error: Argument of type 'ApiError' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 3 problems (3 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: microsoft-ajax
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/microsoft-ajax/microsoft-ajax-tests.ts 782:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 786:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 791:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 3 problems (3 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: photoswipe
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/photoswipe/photoswipe-tests.ts 140:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 145:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 146:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 147:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 4 problems (4 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: hashset
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/hashset/hashset-tests.ts 21:7 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 32:7 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 33:7 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 34:7 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 4 problems (4 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: codemirror
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/codemirror/test/addon/tern/tern.ts 13:15 error TypeScript@local compile error: Argument of type 'string | Error' is not assignable to parameter of type 'string | undefined'. Type 'Error' is not assignable to type 'string' @definitelytyped/expect ✖ 1 problem (1 error, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: signals
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/signals/signals-tests.ts 43:15 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 52:15 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 61:15 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 165:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 175:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 176:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 6 problems (6 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: chrome
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/chrome/test/index.ts 3009:89 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 1 problem (1 error, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: react-swipe
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/react-swipe/react-swipe-tests.tsx 28:15 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 1 problem (1 error, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: snapsvg
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/snapsvg/test/3.ts 12:11 error TypeScript@local compile error: Argument of type 'BBox' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 1 problem (1 error, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: jquery/v1
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/jquery/v1/jquery-tests.ts 1637:15 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 1896:11 error TypeScript@local compile error: Argument of type 'HTMLElement[]' is not assignable to parameter of type 'string' @definitelytyped/expect 1899:11 error TypeScript@local compile error: Argument of type 'HTMLElement' is not assignable to parameter of type 'string' @definitelytyped/expect 2505:15 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 4 problems (4 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: jquery/v2
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/jquery/v2/jquery-tests.ts 1636:15 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 1898:11 error TypeScript@local compile error: Argument of type 'Element[]' is not assignable to parameter of type 'string' @definitelytyped/expect 1901:11 error TypeScript@local compile error: Argument of type 'Element' is not assignable to parameter of type 'string' @definitelytyped/expect 2507:15 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 4 problems (4 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: jquery
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/jquery/test/example-tests.ts 1488:19 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 1516:19 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 1518:19 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 2966:15 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 4113:19 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect /mnt/vss/_work/1/DefinitelyTyped/types/jquery/test/longdesc-tests.ts 471:15 error TypeScript@local compile error: Argument of type 'PlainObject<any>' is not assignable to parameter of type 'string' @definitelytyped/expect 505:15 error TypeScript@local compile error: Argument of type 'PlainObject<any>' is not assignable to parameter of type 'string' @definitelytyped/expect 1692:19 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 1698:19 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 2364:15 error TypeScript@local compile error: Argument of type 'HTMLElement[]' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 10 problems (10 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: jquery-touchswipe
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/jquery-touchswipe/jquery-touchswipe-tests.ts 560:15 error TypeScript@local compile error: Argument of type 'number | JQuery<HTMLElement>' is not assignable to parameter of type 'string | undefined'. Type 'number' is not assignable to type 'string' @definitelytyped/expect ✖ 1 problem (1 error, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: phonegap
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/phonegap/phonegap-tests.ts 605:15 error TypeScript@local compile error: Argument of type 'Event' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 1 problem (1 error, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: three
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/three/test/integration/three-examples/webgl2_rendertarget_texture2darray.ts 144:52 error TypeScript@local compile error: Argument of type 'Uint8Array<ArrayBufferLike>' is not assignable to parameter of type 'BufferSource | null | undefined'. Type 'Uint8Array<ArrayBufferLike>' is not assignable to type 'ArrayBufferView<ArrayBuffer>'. Types of property 'buffer' are incompatible. Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'. Type 'SharedArrayBuffer' is not assignable to type 'ArrayBuffer'. Types of property '[Symbol.toStringTag]' are incompatible. Type '"SharedArrayBuffer"' is not assignable to type '"ArrayBuffer"' @definitelytyped/expect /mnt/vss/_work/1/DefinitelyTyped/types/three/test/unit/examples/jsm/exporters/STLExporter.ts 15:21 error TypeScript@local compile error: Argument of type 'DataView<ArrayBufferLike>' is not assignable to parameter of type 'BufferSource'. Type 'DataView<ArrayBufferLike>' is not assignable to type 'ArrayBufferView<ArrayBuffer>'. Types of property 'buffer' are incompatible. Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'. Type 'SharedArrayBuffer' is not assignable to type 'ArrayBuffer'. Types of property '[Symbol.toStringTag]' are incompatible. Type '"SharedArrayBuffer"' is not assignable to type '"ArrayBuffer"' @definitelytyped/expect ✖ 2 problems (2 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: less
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/less/less-tests.ts 33:15 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 1 problem (1 error, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: lscache
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/lscache/lscache-tests.ts 2:7 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 23:15 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 2 problems (2 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: switchery
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/switchery/switchery-tests.ts 53:15 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 61:15 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect ✖ 2 problems (2 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

You can check the log here.

@typescript-bot
Copy link
Collaborator

@rbuckton Here are the results of running the user tests with tsc comparing main and refs/pull/61647/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Timeout"

Otherwise...

Something interesting changed - please have a look.

Details

effect

tsconfig.json

tsconfig.build.json

@typescript-bot
Copy link
Collaborator

@rbuckton
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
MetricbaselineprDeltaBestWorstp-value
Compiler-Unions - node (v18.15.0, x64)
Errors3434~~~p=1.000 n=6
Symbols62,39062,390~~~p=1.000 n=6
Types50,39550,395~~~p=1.000 n=6
Memory used194,190k (± 0.98%)194,172k (± 0.96%)~192,949k196,594kp=0.689 n=6
Parse Time1.30s (± 0.75%)1.30s (± 0.64%)~1.29s1.31sp=0.588 n=6
Bind Time0.73s0.73s~~~p=1.000 n=6
Check Time9.74s (± 0.35%)9.76s (± 0.20%)~9.75s9.80sp=0.145 n=6
Emit Time2.72s (± 0.76%)2.73s (± 0.30%)~2.72s2.74sp=0.934 n=6
Total Time14.49s (± 0.34%)14.52s (± 0.11%)~14.51s14.55sp=0.196 n=6
angular-1 - node (v18.15.0, x64)
Errors5656~~~p=1.000 n=6
Symbols948,670949,240+570 (+ 0.06%)~~p=0.001 n=6
Types410,947411,065+118 (+ 0.03%)~~p=0.001 n=6
Memory used1,224,331k (± 0.00%)1,225,107k (± 0.00%)+776k (+ 0.06%)1,225,077k1,225,162kp=0.005 n=6
Parse Time6.64s (± 1.05%)6.62s (± 0.80%)~6.55s6.69sp=0.418 n=6
Bind Time1.89s (± 0.40%)1.89s (± 0.27%)~1.88s1.89sp=0.784 n=6
Check Time31.90s (± 0.29%)31.95s (± 0.17%)~31.89s32.02sp=0.227 n=6
Emit Time15.24s (± 0.42%)15.22s (± 0.51%)~15.10s15.32sp=0.689 n=6
Total Time55.67s (± 0.24%)55.68s (± 0.24%)~55.53s55.91sp=0.810 n=6
mui-docs - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols2,361,6672,361,873+206 (+ 0.01%)~~p=0.001 n=6
Types868,625868,652+27 (+ 0.00%)~~p=0.001 n=6
Memory used2,317,097k (± 0.00%)2,317,547k (± 0.00%)+450k (+ 0.02%)2,317,523k2,317,590kp=0.005 n=6
Parse Time8.74s (± 0.35%)8.76s (± 0.29%)~8.72s8.79sp=0.280 n=6
Bind Time2.20s (± 0.57%)2.23s (± 0.74%)+0.03s (+ 1.14%)2.20s2.24sp=0.040 n=6
Check Time69.81s (± 0.43%)69.95s (± 0.28%)~69.74s70.27sp=0.298 n=6
Emit Time0.30s (± 2.98%)0.30s (± 2.52%)~0.29s0.31sp=0.798 n=6
Total Time81.05s (± 0.36%)81.23s (± 0.23%)~81.04s81.53sp=0.199 n=6
self-build-src - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols1,228,0441,228,044~~~p=1.000 n=6
Types267,260267,260~~~p=1.000 n=6
Memory used2,360,689k (± 0.02%)2,360,829k (± 0.02%)~2,360,146k2,361,450kp=0.689 n=6
Parse Time5.20s (± 1.21%)5.23s (± 0.90%)~5.16s5.30sp=0.423 n=6
Bind Time1.80s (± 0.98%)1.80s (± 0.98%)~1.78s1.82sp=0.871 n=6
Check Time35.36s (± 0.39%)35.42s (± 0.18%)~35.33s35.52sp=0.689 n=6
Emit Time3.02s (± 2.50%)2.97s (± 1.85%)~2.89s3.04sp=0.423 n=6
Total Time45.37s (± 0.09%)45.42s (± 0.18%)~45.29s45.53sp=0.173 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols1,228,0441,228,044~~~p=1.000 n=6
Types267,260267,260~~~p=1.000 n=6
Memory used3,037,474k (± 9.77%)3,038,103k (± 9.77%)~2,431,342k3,160,491kp=0.298 n=6
Parse Time6.97s (± 1.02%)6.94s (± 1.48%)~6.78s7.10sp=0.575 n=6
Bind Time2.17s (± 2.40%)2.15s (± 1.85%)~2.10s2.21sp=0.810 n=6
Check Time42.93s (± 0.60%)42.98s (± 0.47%)~42.73s43.17sp=0.748 n=6
Emit Time3.51s (± 1.66%)3.54s (± 1.77%)~3.47s3.62sp=0.378 n=6
Total Time55.58s (± 0.55%)55.61s (± 0.46%)~55.20s55.89sp=1.000 n=6
self-compiler - node (v18.15.0, x64)
Errors00~~~p=1.000 n=6
Symbols263,411263,411~~~p=1.000 n=6
Types107,096107,096~~~p=1.000 n=6
Memory used441,738k (± 0.02%)441,825k (± 0.02%)~441,720k441,913kp=0.066 n=6
Parse Time3.52s (± 0.53%)3.55s (± 0.58%)~3.53s3.58sp=0.121 n=6
Bind Time1.32s (± 0.57%)1.32s (± 0.31%)~1.31s1.32sp=1.000 n=6
Check Time18.96s (± 0.22%)18.95s (± 0.40%)~18.86s19.07sp=0.419 n=6
Emit Time1.53s (± 0.92%)1.54s (± 1.16%)~1.51s1.56sp=0.289 n=6
Total Time25.33s (± 0.18%)25.35s (± 0.29%)~25.24s25.42sp=0.746 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors7171~~~p=1.000 n=6
Symbols225,981225,981~~~p=1.000 n=6
Types94,35694,356~~~p=1.000 n=6
Memory used371,461k (± 0.06%)371,351k (± 0.06%)~371,143k371,790kp=0.471 n=6
Parse Time2.89s (± 1.40%)2.88s (± 0.90%)~2.85s2.91sp=0.688 n=6
Bind Time1.59s (± 1.02%)1.59s (± 1.30%)~1.57s1.62sp=0.935 n=6
Check Time16.51s (± 0.48%)16.48s (± 0.27%)~16.43s16.56sp=0.872 n=6
Emit Time0.00s (±244.70%)0.00s (±244.70%)~0.00s0.01sp=1.000 n=6
Total Time20.99s (± 0.59%)20.96s (± 0.14%)~20.92s20.99sp=0.872 n=6
vscode - node (v18.15.0, x64)
Errors419🔻+15 (+375.00%)~~p=0.001 n=6
Symbols3,391,6573,393,646+1,989 (+ 0.06%)~~p=0.001 n=6
Types1,148,5981,149,028+430 (+ 0.04%)~~p=0.001 n=6
Memory used3,443,255k (± 0.01%)3,444,660k (± 0.01%)+1,405k (+ 0.04%)3,444,064k3,444,907kp=0.005 n=6
Parse Time14.72s (± 0.38%)14.73s (± 0.42%)~14.66s14.82sp=1.000 n=6
Bind Time4.72s (± 0.35%)4.76s (± 1.00%)~4.70s4.82sp=0.226 n=6
Check Time92.86s (± 1.44%)92.91s (± 1.92%)~91.61s96.48sp=1.000 n=6
Emit Time29.96s (± 2.03%)30.02s (± 1.82%)~29.68s31.13sp=0.378 n=6
Total Time142.25s (± 1.37%)142.42s (± 1.64%)~140.74s147.13sp=0.873 n=6
webpack - node (v18.15.0, x64)
Errors22~~~p=1.000 n=6
Symbols317,345317,567+222 (+ 0.07%)~~p=0.001 n=6
Types140,331140,470+139 (+ 0.10%)~~p=0.001 n=6
Memory used472,437k (± 0.02%)472,941k (± 0.01%)+504k (+ 0.11%)472,880k473,025kp=0.005 n=6
Parse Time5.20s (± 0.29%)5.17s (± 0.57%)~5.13s5.22sp=0.075 n=6
Bind Time2.26s (± 0.88%)2.24s (± 0.46%)~2.23s2.26sp=0.162 n=6
Check Time25.87s (± 0.60%)25.91s (± 0.08%)~25.88s25.94sp=0.630 n=6
Emit Time0.00s (±244.70%)0.00s~~~p=0.405 n=6
Total Time33.33s (± 0.44%)33.32s (± 0.09%)~33.29s33.36sp=0.378 n=6
xstate-main - node (v18.15.0, x64)
Errors55~~~p=1.000 n=6
Symbols570,517570,733+216 (+ 0.04%)~~p=0.001 n=6
Types191,417191,446+29 (+ 0.02%)~~p=0.001 n=6
Memory used500,889k (± 0.03%)501,299k (± 0.01%)+410k (+ 0.08%)501,220k501,392kp=0.005 n=6
Parse Time4.30s (± 0.38%)4.32s (± 0.59%)~4.28s4.36sp=0.190 n=6
Bind Time1.52s (± 1.70%)1.53s (± 1.20%)~1.50s1.55sp=0.567 n=6
Check Time25.13s (± 1.62%)24.88s (± 0.18%)-0.25s (- 0.98%)24.82s24.94sp=0.024 n=6
Emit Time0.00s0.00s~~~p=1.000 n=6
Total Time30.96s (± 1.28%)30.74s (± 0.21%)~30.64s30.80sp=0.109 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
BenchmarkNameIterations
Currentpr6
Baselinebaseline6

Developer Information:

Download Benchmarks

@rbuckton
Copy link
ContributorAuthor

A large number of failures seem to be due to the signature of alert() changing in the output from TypeScript-DOM-lib-generator

@typescript-bot
Copy link
Collaborator

@rbuckton Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61647/merge:

Something interesting changed - please have a look.

Details

actualbudget/actual

1 of 6 projects failed to build with the old tsc and were ignored

tsconfig.json

packages/loot-core/tsconfig.api.json

adobe/react-spectrum

10 of 15 projects failed to build with the old tsc and were ignored

examples/rsp-cra-18/tsconfig.json

apollographql/apollo-client

1 of 13 projects failed to build with the old tsc and were ignored

tsconfig.json

src/tsconfig.json

better-auth/better-auth

15 of 17 projects failed to build with the old tsc and were ignored

packages/better-auth/tsconfig.declarations.json

FlowiseAI/Flowise

1 of 3 projects failed to build with the old tsc and were ignored

packages/components/tsconfig.json

hoppscotch/hoppscotch

10 of 18 projects failed to build with the old tsc and were ignored

packages/hoppscotch-kernel/tsconfig.json

packages/hoppscotch-kernel/tsconfig.decl.json

immich-app/immich

3 of 7 projects failed to build with the old tsc and were ignored

server/tsconfig.build.json

ionic-team/ionic-framework

24 of 25 projects failed to build with the old tsc and were ignored

core/tsconfig.json

labring/FastGPT

7 of 12 projects failed to build with the old tsc and were ignored

projects/app/tsconfig.json

microsoft/vscode

5 of 55 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

src/tsconfig.monaco.json

extensions/notebook-renderers/tsconfig.json

shoelace-style/shoelace

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.prod.json

signalapp/Signal-Desktop

1 of 2 projects failed to build with the old tsc and were ignored

sticker-creator/tsconfig.json

socketio/socket.io

13 of 32 projects failed to build with the old tsc and were ignored

packages/engine.io-parser/tsconfig.json

packages/engine.io-parser/tsconfig.esm.json

t3-oss/create-t3-app

1 of 5 projects failed to build with the old tsc and were ignored

www/tsconfig.json

  • error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'BodyInit | null | undefined'.

Tonejs/Tone.js

1 of 2 projects failed to build with the old tsc and were ignored

scripts/tsconfig.build.json

tremorlabs/tremor-npm

tsconfig.json

trpc/trpc

37 of 43 projects failed to build with the old tsc and were ignored

packages/tests/tsconfig.json

packages/tanstack-react-query/tsconfig.json

packages/next/tsconfig.json

packages/client/tsconfig.json

@jakebailey
Copy link
Member

A large number of failures seem to be due to the signature of alert() changing in the output from TypeScript-DOM-lib-generator

FYI @saschanaz@Bashamega

@rbuckton
Copy link
ContributorAuthor

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 2, 2025

Starting jobs; this comment will be updated as builds start and complete.

CommandStatusResults
run dt✅ Started

@rbuckton
Copy link
ContributorAuthor

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 2, 2025

Starting jobs; this comment will be updated as builds start and complete.

CommandStatusResults
run dt✅ Started👀 Results

@saschanaz
Copy link
Contributor

A large number of failures seem to be due to the signature of alert() changing in the output from TypeScript-DOM-lib-generator

FYI @saschanaz@Bashamega

Any idea what the failure looks like?

@saschanaz
Copy link
Contributor

Err, okay, alert(number). Oh no.

@saschanaz
Copy link
Contributor

saschanaz commented May 2, 2025

I guess we should backout the PR. I thought nobody would do this... 😅

@saschanaz
Copy link
Contributor

Actually I'm talking about https://github.com/microsoft/TypeScript/actions/runs/14803024546/job/41565917783?pr=61647, but that's just an internal test?

@typescript-bot
Copy link
Collaborator

Hey @rbuckton, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: w3c-image-capture
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/w3c-image-capture/index.d.ts 3:15 error TypeScript@local compile error: Duplicate identifier 'ImageCapture' @definitelytyped/expect 18:14 error TypeScript@local compile error: All declarations of 'redEyeReduction' must have identical modifiers @definitelytyped/expect 18:14 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'redEyeReduction' must be of type 'RedEyeReduction | undefined', but here has type 'RedEyeReduction' @definitelytyped/expect 19:14 error TypeScript@local compile error: All declarations of 'imageHeight' must have identical modifiers @definitelytyped/expect 19:14 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'imageHeight' must be of type 'MediaSettingsRange | undefined', but here has type 'MediaSettingsRange' @definitelytyped/expect 20:14 error TypeScript@local compile error: All declarations of 'imageWidth' must have identical modifiers @definitelytyped/expect 20:14 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'imageWidth' must be of type 'MediaSettingsRange | undefined', but here has type 'MediaSettingsRange' @definitelytyped/expect 21:14 error TypeScript@local compile error: All declarations of 'fillLightMode' must have identical modifiers @definitelytyped/expect 21:14 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'fillLightMode' must be of type 'FillLightMode[] | undefined', but here has type 'FillLightMode[]' @definitelytyped/expect 32:14 error TypeScript@local compile error: All declarations of 'max' must have identical modifiers @definitelytyped/expect 32:14 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'max' must be of type 'number | undefined', but here has type 'number' @definitelytyped/expect 33:14 error TypeScript@local compile error: All declarations of 'min' must have identical modifiers @definitelytyped/expect 33:14 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'min' must be of type 'number | undefined', but here has type 'number' @definitelytyped/expect 34:14 error TypeScript@local compile error: All declarations of 'step' must have identical modifiers @definitelytyped/expect 34:14 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'step' must be of type 'number | undefined', but here has type 'number' @definitelytyped/expect 37:6 error TypeScript@local compile error: Duplicate identifier 'RedEyeReduction' @definitelytyped/expect 38:6 error TypeScript@local compile error: Duplicate identifier 'FillLightMode' @definitelytyped/expect 88:5 error TypeScript@local compile error: Subsequent property declarations must have the same type. Property 'whiteBalanceMode' must be of type 'string | undefined', but here has type 'MeteringMode | undefined' @definitelytyped/expect /mnt/vss/_work/1/DefinitelyTyped/types/w3c-image-capture/w3c-image-capture-tests.ts 24:29 error TypeScript@local compile error: Object is possibly 'undefined' @definitelytyped/expect 25:29 error TypeScript@local compile error: Object is possibly 'undefined' @definitelytyped/expect 26:30 error TypeScript@local compile error: Object is possibly 'undefined' @definitelytyped/expect 68:26 error TypeScript@local compile error: Property 'grabFrame' does not exist on type 'ImageCapture' @definitelytyped/expect 70:24 error TypeScript@local compile error: Parameter 'err' implicitly has an 'any' type @definitelytyped/expect 103:22 error TypeScript@local compile error: Property 'grabFrame' does not exist on type 'ImageCapture' @definitelytyped/expect 105:20 error TypeScript@local compile error: Parameter 'err' implicitly has an 'any' type @definitelytyped/expect 158:21 error TypeScript@local compile error: 'capabilities.focusDistance.min' is possibly 'undefined' @definitelytyped/expect 159:21 error TypeScript@local compile error: 'capabilities.focusDistance.max' is possibly 'undefined' @definitelytyped/expect 160:22 error TypeScript@local compile error: 'capabilities.focusDistance.step' is possibly 'undefined' @definitelytyped/expect ✖ 28 problems (28 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: node
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/node/test/globals-dom.ts 63:5 error TypeScript@local tsconfig.dom.json, local tsconfig.webworker.json expected type to be: ReadableStream<Uint8Array> || ReadableStream<Uint8Array<ArrayBufferLike>> got: ReadableStream<Uint8Array<ArrayBuffer>> @definitelytyped/expect 64:5 error TypeScript@local tsconfig.dom.json, local tsconfig.webworker.json expected type to be: ReadableStream<any> || ReadableStream<Uint8Array<ArrayBufferLike>> got: ReadableStream<Uint8Array<ArrayBuffer>> @definitelytyped/expect 65:5 error TypeScript@local tsconfig.dom.json, local tsconfig.webworker.json expected type to be: ReadableStream<any> || ReadableStream<Uint8Array<ArrayBufferLike>> got: ReadableStream<Uint8Array<ArrayBuffer>> @definitelytyped/expect ✖ 3 problems (3 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

Package: three
Error:

Error: /mnt/vss/_work/1/DefinitelyTyped/types/three/test/integration/three-examples/webgl2_rendertarget_texture2darray.ts 144:52 error TypeScript@local compile error: Argument of type 'Uint8Array<ArrayBufferLike>' is not assignable to parameter of type 'BufferSource | null | undefined'. Type 'Uint8Array<ArrayBufferLike>' is not assignable to type 'ArrayBufferView<ArrayBuffer>'. Types of property 'buffer' are incompatible. Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'. Type 'SharedArrayBuffer' is not assignable to type 'ArrayBuffer'. Types of property '[Symbol.toStringTag]' are incompatible. Type '"SharedArrayBuffer"' is not assignable to type '"ArrayBuffer"' @definitelytyped/expect /mnt/vss/_work/1/DefinitelyTyped/types/three/test/unit/examples/jsm/exporters/STLExporter.ts 15:21 error TypeScript@local compile error: Argument of type 'DataView<ArrayBufferLike>' is not assignable to parameter of type 'BufferSource'. Type 'DataView<ArrayBufferLike>' is not assignable to type 'ArrayBufferView<ArrayBuffer>'. Types of property 'buffer' are incompatible. Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'. Type 'SharedArrayBuffer' is not assignable to type 'ArrayBuffer'. Types of property '[Symbol.toStringTag]' are incompatible. Type '"SharedArrayBuffer"' is not assignable to type '"ArrayBuffer"' @definitelytyped/expect ✖ 2 problems (2 errors, 0 warnings) at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28) at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20) 

You can check the log here.

Copy link
Member

@sandersnsandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides ArrayBufferLike, it's almost all additions. Plus tonnes of comment changes.

@saschanaz
Copy link
Contributor

saschanaz commented May 5, 2025

Actually I'm talking about https://github.com/microsoft/TypeScript/actions/runs/14803024546/job/41565917783?pr=61647, but that's just an internal test?

See #61647 (comment). A large percentage of the DT tests failures are due to the signature of alert() changing.

I don't see any match of alert there, what am I missing?

@rbuckton
Copy link
ContributorAuthor

Actually I'm talking about https://github.com/microsoft/TypeScript/actions/runs/14803024546/job/41565917783?pr=61647, but that's just an internal test?

See #61647 (comment). A large percentage of the DT tests failures are due to the signature of alert() changing.

I don't see any match of alert there, what am I missing?

Package: ckeditor4 Error: Error: /mnt/vss/_work/1/DefinitelyTyped/types/ckeditor4/ckeditor4-tests.ts 20:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 115:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 134:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 139:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 142:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 143:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 145:11 error TypeScript@local compile error: Argument of type 'unknown' is not assignable to parameter of type 'string | undefined' @definitelytyped/expect 146:11 error TypeScript@local compile error: Argument of type 'unknown' is not assignable to parameter of type 'string | undefined' @definitelytyped/expect 158:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 192:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect 194:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 195:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 197:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 198:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 199:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 200:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 201:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 227:11 error TypeScript@local compile error: Argument of type 'boolean' is not assignable to parameter of type 'string' @definitelytyped/expect 257:11 error TypeScript@local compile error: Argument of type 'number' is not assignable to parameter of type 'string' @definitelytyped/expect ... 

@saschanaz
Copy link
Contributor

Ah, the "is not assignable to parameter of type 'string'" errors. Err, still looks like something TS test specific, but perhaps also maybe an early smoke of something bigger. I'm open to backout.

@rbuckton
Copy link
ContributorAuthor

Ah, the "is not assignable to parameter of type 'string'" errors. Err, still looks like something TS test specific, but perhaps also maybe an early smoke of something bigger. I'm open to backout.

There are similar errors in the user tests, though not as frequent.

@rbuckton
Copy link
ContributorAuthor

@typescript-bot run dt
@typescript-bot test top400
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 5, 2025

Starting jobs; this comment will be updated as builds start and complete.

CommandStatusResults
run dt✅ Started✅ Results
test top400✅ Started👀 Results
user test this✅ Started👀 Results

@typescript-bot
Copy link
Collaborator

@rbuckton Here are the results of running the user tests with tsc comparing main and refs/pull/61647/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Timeout"

Otherwise...

Something interesting changed - please have a look.

Details

effect

tsconfig.json

tsconfig.build.json

@typescript-bot
Copy link
Collaborator

Hey @rbuckton, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@rbuckton Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61647/merge:

Something interesting changed - please have a look.

Details

actualbudget/actual

1 of 6 projects failed to build with the old tsc and were ignored

tsconfig.json

packages/loot-core/tsconfig.api.json

apollographql/apollo-client

1 of 13 projects failed to build with the old tsc and were ignored

tsconfig.json

src/tsconfig.json

better-auth/better-auth

15 of 17 projects failed to build with the old tsc and were ignored

packages/better-auth/tsconfig.declarations.json

FlowiseAI/Flowise

1 of 3 projects failed to build with the old tsc and were ignored

packages/components/tsconfig.json

hoppscotch/hoppscotch

10 of 18 projects failed to build with the old tsc and were ignored

packages/hoppscotch-kernel/tsconfig.json

packages/hoppscotch-kernel/tsconfig.decl.json

immich-app/immich

3 of 7 projects failed to build with the old tsc and were ignored

server/tsconfig.build.json

ionic-team/ionic-framework

24 of 25 projects failed to build with the old tsc and were ignored

core/tsconfig.json

labring/FastGPT

7 of 12 projects failed to build with the old tsc and were ignored

projects/app/tsconfig.json

microsoft/vscode

5 of 55 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

src/tsconfig.monaco.json

extensions/notebook-renderers/tsconfig.json

shoelace-style/shoelace

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.prod.json

signalapp/Signal-Desktop

1 of 2 projects failed to build with the old tsc and were ignored

sticker-creator/tsconfig.json

socketio/socket.io

13 of 32 projects failed to build with the old tsc and were ignored

packages/engine.io-parser/tsconfig.json

packages/engine.io-parser/tsconfig.esm.json

t3-oss/create-t3-app

1 of 5 projects failed to build with the old tsc and were ignored

www/tsconfig.json

  • error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'BodyInit | null | undefined'.

Tonejs/Tone.js

1 of 2 projects failed to build with the old tsc and were ignored

scripts/tsconfig.build.json

trpc/trpc

37 of 43 projects failed to build with the old tsc and were ignored

packages/tests/tsconfig.json

packages/tanstack-react-query/tsconfig.json

packages/next/tsconfig.json

packages/client/tsconfig.json

@rbuckton
Copy link
ContributorAuthor

@typescript-bot: pack this

@jakebailey
Copy link
Member

The bot is broken, I am fixing it. (your command also has a colon after the username which probably wouldn't work)

@rbuckton
Copy link
ContributorAuthor

The bot is broken, I am fixing it. (your command also has a colon after the username which probably wouldn't work)

I have that as a "Saved Reply" on GitHub. It's always worked in the past.

@rbuckton
Copy link
ContributorAuthor

The errors in effect should be addressed by Effect-TS/effect#4834.

@jakebailey
Copy link
Member

I have that as a "Saved Reply" on GitHub. It's always worked in the past.

Oh right, I forgot I made that work in microsoft/typescript-bot-test-triggerer@bb85856

@rbuckton
Copy link
ContributorAuthor

I've also put a PR up for VSCode here: microsoft/vscode#248346

@jakebailey
Copy link
Member

Should we revert that alert PR first? (I am still working on fixing the bot to retest this ☹️)

@rbuckton
Copy link
ContributorAuthor

Should we revert that alert PR first? (I am still working on fixing the bot to retest this ☹️)

No, the revert we made here was also made to TypeScript-DOM-lib-generator: microsoft/TypeScript-DOM-lib-generator#2015

@jakebailey
Copy link
Member

Ah, great; I just hadn't gotten that far into my inbox.

@rbucktonrbuckton merged commit 8c62e08 into mainMay 7, 2025
32 checks passed
@rbucktonrbuckton deleted the dom-update-2025-05-02 branch May 7, 2025 22:02
@github-project-automationgithub-project-automationbot moved this from Needs merge to Done in PR BacklogMay 7, 2025
@microsoftmicrosoft locked as resolved and limited conversation to collaborators Nov 4, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: TeamFor Uncommitted BugPR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

AllowSharedBufferSource definition is incorrect

8 participants

@rbuckton@typescript-bot@jakebailey@saschanaz@Bashamega@stwlam@sandersn