Better typings for Promise.then(), like #31117#33103
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jablkoforce-pushed the patch-6 branch 2 times, most recently from fb7d414 to 9855ca6Comparejablkoforce-pushed the patch-6 branch 3 times, most recently from 807672f to dbd8fefComparejablkoforce-pushed the patch-6 branch 4 times, most recently from 57c746f to 0e5392bComparejablkoforce-pushed the patch-6 branch 2 times, most recently from 1abb98b to 2409b6eComparejablkoforce-pushed the patch-6 branch 2 times, most recently from a720dc6 to a7ba115Comparejablkoforce-pushed the patch-6 branch 2 times, most recently from 123fb1b to 5b1a139Comparejablkoforce-pushed the patch-6 branch 5 times, most recently from 26402ab to ada7592Comparejablkoforce-pushed the patch-6 branch 3 times, most recently from babef3b to 09cad11Compare
jablkoforce-pushed the patch-6 branch 4 times, most recently from 2f142db to e28f834Comparejablkoforce-pushed the patch-6 branch 5 times, most recently from e31427a to d2c03e0Compare
Contributor
rbuckton commented Mar 18, 2022
I'm concerned that these types would conflict with userland promise definitions. Also, the linked issue was closed by #45350, so I am closing this. |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#30390