Better typings for Array.concat()#33606
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Jessidhia suggested changes Sep 26, 2019
Jessidhia left a comment
Jessidhia left a comment There was a problem hiding this comment.
You probably need to keep at least the less-generic overload around as the first overload.
As it is, the free U parameter will prevent inference from working in cases where one is trying to build a homogeneous array; especially when the array includes function or object types that might have methods.
constfoo=[(a: string)=>a]constbar=foo.concat(b=>b)// implicit any error
jablkoforce-pushed the patch-9 branch 2 times, most recently from 337078d to eb23428CompareContributorAuthor
jablko commented Sep 27, 2019
@Jessidhia Thank you for this feedback! I've now updated the PR accordingly. |
jablkoforce-pushed the patch-9 branch 2 times, most recently from 34b5a8e to d24988cComparejablkoforce-pushed the patch-9 branch 3 times, most recently from 47ac9d2 to 2d8c8eaComparejablkoforce-pushed the patch-9 branch 2 times, most recently from 944ef0f to 0693442Comparejablkoforce-pushed the patch-9 branch 2 times, most recently from 5336214 to 40063feComparejablkoforce-pushed the patch-9 branch 5 times, most recently from 50c57c6 to 3ec86d2Comparejablkoforce-pushed the patch-9 branch 3 times, most recently from cbf4fc2 to dd89dbeCompare
Member
RyanCavanaugh commented Jan 31, 2020
Rolled into #33645 |
Collaborator
typescript-bot commented Oct 21, 2025
The TypeScript team hasn't accepted the linked issue #26378. If you can get it accepted, this PR will have a better chance of being reviewed. |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#26378
Fixes#26976