Skip to content

Conversation

@jablko
Copy link
Contributor

@jablkojablko commented Sep 27, 2019

Roll up #33606, #33620 and #33630

Fixes#19535
Fixes#24579
Fixes#26378
Fixes#26976
Fixes#29604
Fixes#31033

@jablkojablkoforce-pushed the patch-13 branch 5 times, most recently from 7cf1280 to b23d8adCompareSeptember 30, 2019 01:29
@jablkojablko changed the title Better typings for Array.concat() and .flatMap()Better typings for Array.concat(), etc.Sep 30, 2019
@jablkojablkoforce-pushed the patch-13 branch 9 times, most recently from 684dc5d to ee4c5e6CompareOctober 7, 2019 14:31
@jablkojablkoforce-pushed the patch-13 branch 2 times, most recently from 98115c4 to a448f91CompareOctober 16, 2019 14:46
@jablkojablkoforce-pushed the patch-13 branch 2 times, most recently from 0e26a78 to 6b277e3CompareOctober 19, 2019 18:33
@jablkojablkoforce-pushed the patch-13 branch 3 times, most recently from 97d14d8 to 0faa4edCompareNovember 17, 2019 14:28
@jablko
Copy link
ContributorAuthor

@typescript-bot test this
@typescript-bot run dt
@typescript-bot user test this

@orta
Copy link
Contributor

orta commented Nov 18, 2019

@typescript-bot test this
@typescript-bot run dt
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 18, 2019

Heya @orta, I've started to run the extended test suite on this PR at 032ede6. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 18, 2019

Heya @orta, I've started to run the parallelized Definitely Typed test suite on this PR at 032ede6. You can monitor the build here. It should now contribute to this PR's status checks.

@jablkojablkoforce-pushed the patch-13 branch 3 times, most recently from 2c3101c to 0056e90CompareJanuary 29, 2020 01:06
@RyanCavanaugh
Copy link
Member

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 31, 2020

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 0056e90. You can monitor the build here. It should now contribute to this PR's status checks.

@jablko
Copy link
ContributorAuthor

@RyanCavanaugh Thanks! Could I please trouble you to trigger @typescript-bot run dt as well?

@RyanCavanaugh
Copy link
Member

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 3, 2020

Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at 77844cc. You can monitor the build here. It should now contribute to this PR's status checks.

@jablkojablkoforce-pushed the patch-13 branch 2 times, most recently from 43679d2 to 1c95e0eCompareFebruary 4, 2020 18:52
@jablkojablkoforce-pushed the patch-13 branch 2 times, most recently from 8efba07 to 1e82814CompareFebruary 13, 2020 15:42
@sandersn
Copy link
Member

@DanielRosenwasser we should probably discuss this in a design meeting after we get an analysis of how breaky it is to user/DT/RWC tests. Though maybe we should hold this until after the existing effort to gather broken Array examples is done.

@sandersnsandersn self-assigned this Mar 10, 2020
@ljharb
Copy link
Contributor

Any update on this? I'm hoping it allows for idiomatic usage of eg [].concat(a || [], b || []).

@sandersn
Copy link
Member

This has been sitting for a long time, and a big part of that is the difficulty in making any change to array types. I think it has to be a single major update like #36554 nowadays. I'm going to close this PR, although it may be useful as a basis for a part of that work.

@sandersnsandersn closed this Mar 3, 2022
@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #19535. If you can get it accepted, this PR will have a better chance of being reviewed.

@microsoftmicrosoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.