- Notifications
You must be signed in to change notification settings - Fork 13.2k
Better typings for Array.concat(), etc.#33645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
jablko commented Sep 27, 2019 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
7cf1280 to b23d8adCompare684dc5d to ee4c5e6Compare98115c4 to a448f91Compare0e26a78 to 6b277e3Compare97d14d8 to 0faa4edComparejablko commented Nov 17, 2019
@typescript-bot test this |
orta commented Nov 18, 2019
@typescript-bot test this |
typescript-bot commented Nov 18, 2019 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
typescript-bot commented Nov 18, 2019 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
2c3101c to 0056e90CompareRyanCavanaugh commented Jan 31, 2020
@typescript-bot test this |
typescript-bot commented Jan 31, 2020 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 0056e90. You can monitor the build here. It should now contribute to this PR's status checks. |
jablko commented Feb 3, 2020
@RyanCavanaugh Thanks! Could I please trouble you to trigger @typescript-bot run dt as well? |
RyanCavanaugh commented Feb 3, 2020
@typescript-bot run dt |
typescript-bot commented Feb 3, 2020 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at 77844cc. You can monitor the build here. It should now contribute to this PR's status checks. |
43679d2 to 1c95e0eCompare8efba07 to 1e82814Comparesandersn commented Mar 9, 2020
@DanielRosenwasser we should probably discuss this in a design meeting after we get an analysis of how breaky it is to user/DT/RWC tests. Though maybe we should hold this until after the existing effort to gather broken Array examples is done. |
ljharb commented Jan 8, 2022
Any update on this? I'm hoping it allows for idiomatic usage of eg |
sandersn commented Mar 3, 2022
This has been sitting for a long time, and a big part of that is the difficulty in making any change to array types. I think it has to be a single major update like #36554 nowadays. I'm going to close this PR, although it may be useful as a basis for a part of that work. |
typescript-bot commented Mar 3, 2022
The TypeScript team hasn't accepted the linked issue #19535. If you can get it accepted, this PR will have a better chance of being reviewed. |
Roll up #33606, #33620 and #33630
Fixes#19535
Fixes#24579
Fixes#26378
Fixes#26976
Fixes#29604
Fixes#31033