In JSDoc, parse postfix-? below conditional types/tuple types#39123
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Outside of JSDoc comments, postfix-? is parsed at lower precedence than the `?` of conditional types, and a postfix-? inside a tuple type results in the type being marked optional. This PR changes JSDoc parsing to behave the same way, which means that 1. Conditional types are allowed in JSDoc. Fixes#37166. 2. Tuple types' postfix-? syntax is interpreted correctly in JSDoc. Fixes#38747. The breaking change is that a postfix-? type followed by another postfix type, like `[]` or `!`, is parsed as a conditional type. [Postfix-? is not common](#37166 (comment)), so this is an acceptable breaking change. A postfix-? type `T?` is still parsed everywhere else and treated as `T | null`.
MemberAuthor
sandersn commented Jun 17, 2020
@typescript-bot user test this -- let's see if any of Google's open source uses postfix-? |
Collaborator
MemberAuthor
sandersn commented Jun 17, 2020
@DanielRosenwasser pretty sure this is not going to break anyone -- think it should go into 4.0? |
RyanCavanaugh approved these changes Jun 17, 2020
Collaborator
typescript-bot commented Jun 17, 2020
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
MemberAuthor
sandersn commented Jun 17, 2020
No changes to user tests! I think this is safe for 4.0. |
| @@ -3356,7 +3356,7 @@ namespace ts{ | |||
| break; | |||
| case SyntaxKind.QuestionToken: | |||
| // If not in JSDoc and next token is start of a type we have a conditional type | |||
Member
There was a problem hiding this comment.
Comment appears to be out of date?
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outside of JSDoc comments, postfix-? is parsed at lower precedence than the
?of conditional types, and a postfix-? inside a tuple type results in the type being marked optional.This PR changes JSDoc parsing to behave the same way, which means that
The breaking change is that a postfix-? type followed by another postfix type, like
[]or!, is parsed as a conditional type. Postfix-? is not common, so this is an acceptable breaking change.A postfix-? type
T?is still parsed everywhere else and treated asT | null.