Add missing index.ts files to user projects#39163
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This makes the language service treat .js files inside node_modules as part of the parent project, so that you can view the same errors in the editor as you see in the baselines. Also update a comment in the parser that I missed in an earlier PR.
weswigham approved these changes Jun 20, 2020
Member
weswigham left a comment
weswigham left a comment There was a problem hiding this comment.
Are there baseline updates to go with this?
MemberAuthor
sandersn commented Jun 22, 2020
I don't think so, but let me check: @typescript-bot user test this |
Collaborator
Collaborator
typescript-bot commented Jun 22, 2020
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
MemberAuthor
sandersn commented Jun 22, 2020
Nope, no changes to the baselines. The batch compiler already checked .js files, it was just the language service that changed to no longer make .js files inside node_modules part of the project. |
cangSDARM added a commit to cangSDARM/TypeScript that referenced this pull request Jun 23, 2020
* upstream/master: (58 commits) Variadic tuple types (microsoft#39094) chore: resolve suggestions Expand auto-import to all package.json dependencies (microsoft#38923) inline local functions Update bigint declaration file (microsoft#38526) Update user baselines (microsoft#39077) LEGO: check in for master to temporary branch. Add missing index.ts files to user projects (microsoft#39163) Add reason for a disabled code action (microsoft#37871) Minor fix for assertion predicates (microsoft#38710) Update LKG (microsoft#39173) Reparse top level 'await' in modules (microsoft#39084) change chore: more change chore: resolve review chore: save space fix: lint error test: add test for it chore: make isJsxAttr required chore: revert change in checker ... # Conflicts: # src/compiler/binder.ts # src/compiler/checker.ts # src/compiler/parser.ts # src/compiler/types.ts
Jack-Works pushed a commit to Jack-Works/TypeScript that referenced this pull request Jun 24, 2020
This makes the language service treat .js files inside node_modules as part of the parent project, so that you can view the same errors in the editor as you see in the baselines. Also update a comment in the parser that I missed in an earlier PR.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the language service treat .js files inside node_modules as
part of the parent project, so that you can view the same errors in the
editor as you see in the baselines.
Also update a comment in the parser that I missed in an earlier PR. (#39123)