- Notifications
You must be signed in to change notification settings - Fork 9
post: v23.4.0 announcement#17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
joyeecheung left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though I wish we had a bit more summary about the new features in the text?
(Speaking of which, we should also add the character length limit validation to the workflow).
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Joyee Cheung <[email protected]>
joyeecheung commented Dec 10, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
I am typing on my phone so I don't know if these fit in 300 chars, but I think this is the list that can be put into the post (maybe we can cut some if it's too long, or we can send a reply to the first post)
According to my testing in joyeecheung/bluesky-playground#10 line breaks via \n works. |
aduh95 commented Dec 10, 2024
Yeah the following text is already 283 char, it would need to be a response – which I think needs to be another PR, I don't think we support making threads Notable changes: -`assert.partialDeepStrictEqual()`-`--trace-env`-`net.BlockList.isBlockList()`-`net.SocketAddress.parse()`- BlockList support in `net.Server` and `net.connect`- unflag `node:sqlite`-`StatementSync.prototype.iterate()`- new Collaborator @jordan.har.band |
joyeecheung commented Dec 10, 2024
How about It's 289 chars, and we can add |
joyeecheung commented Dec 10, 2024
(Also another note, we can support file reference in the JSON, so that the rich text content can be put into a .txt, and the workflow can read it and JSON.stringify it) |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Antoine du Hamel <[email protected]>
joyeecheung commented Dec 10, 2024
I tested it in joyeecheung/bluesky-playground#11 which triggered https://bsky.app/profile/pixel-voyager.bsky.social/post/3lcxuadloj62p - looks good! |
53ca786 into mainUh oh!
There was an error while loading. Please reload this page.
joyeecheung commented Dec 10, 2024
It seems the branch deletion is automatic, after some googling I found So I disabled it in the repo setting. |
* post: v23.4.0 announcement * Update records/new/v23.4.0-announcement.json Co-authored-by: Joyee Cheung <[email protected]> * Update records/new/v23.4.0-announcement.json Co-authored-by: Antoine du Hamel <[email protected]> --------- Co-authored-by: Joyee Cheung <[email protected]>
* post: v23.4.0 announcement (#17) * post: v23.4.0 announcement * Update records/new/v23.4.0-announcement.json Co-authored-by: Joyee Cheung <[email protected]> * Update records/new/v23.4.0-announcement.json Co-authored-by: Antoine du Hamel <[email protected]> --------- Co-authored-by: Joyee Cheung <[email protected]> * Update v23.4.0-announcement.json --------- Co-authored-by: Antoine du Hamel <[email protected]>
joyeecheung commented Dec 10, 2024
About It seems a repost of https://bsky.app/profile/jordan.har.band/post/3lcixvbt24k2e is more apt? |
Refs: nodejs/node#56119