Skip to content

Conversation

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-botnodejs-github-bot commented Dec 3, 2024

2024-12-10, Version 23.4.0 (Current), @targos

Notable Changes

Introducing experimental assert.partialDeepStrictEqual

Sometimes, when writing test, we want to validate that some specific properties
are present, and the mere presence of additional keys are not exactly relevant
for that specific test. For this use case, we can now use
assert.partialDeepStrictEqual, which should be familiar to those already using
assert.deepStrictEqual, with the main difference that it does not require all
properties in the actual parameter to be present in the expected parameter.

Here are a few examples of usage:

assert.partialDeepStrictEqual({a: 1,b: 2,c: 3},{a: 1,b: 2},);assert.partialDeepStrictEqual([1,2,3,4],[2,3],);assert.partialDeepStrictEqual({a: {b: {c: 1,d: 2}},e: 3},{a: {b: {c: 1}}},);assert.partialDeepStrictEqual({a: {b: {c: 1,d: 2}},e: 3},{a: {b: {c: 1}}},);assert.partialDeepStrictEqual(newSet([{a: 1},{b: 1}]),newSet([{a: 1}]),);assert.partialDeepStrictEqual({a: newSet([{a: 1},{b: 1}]),b: newMap(),c: [1,2,3]},{a: newSet([{a: 1}]),c: [2]},);

Contributed by Giovanni Bucci in #54630.

Other notable changes

  • [816d37a187] - (SEMVER-MINOR)cli: implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
  • [59d6891872] - doc: add LJHarb to collaborators (Jordan Harband) #56132
  • [565b04a7be] - (SEMVER-MINOR)net: add BlockList.isBlockList(value) (James M Snell) #56078
  • [c9698ed6a4] - (SEMVER-MINOR)net: support blockList in net.connect (theanarkh) #56075
  • [30d604180d] - (SEMVER-MINOR)net: support blockList in net.Server (theanarkh) #56079
  • [9fba5e1df1] - (SEMVER-MINOR)net: add SocketAddress.parse (James M Snell) #56076
  • [4cdb03201e] - (SEMVER-MINOR)process: deprecate features.{ipv6,uv} and features.tls_* (René) #55545
  • [efb9f05f59] - (SEMVER-MINOR)sqlite: unflag node:sqlite module (Colin Ihrig) #55890
  • [d777d4a52d] - (SEMVER-MINOR)sqlite: add StatementSync.prototype.iterate method (tpoisseau) #54213

Commits

  • [5b0ce376a2] - assert: optimize partial comparison of two Sets (Antoine du Hamel) #55970
  • [a4f57f0293] - (SEMVER-MINOR)assert: add partialDeepStrictEqual (Giovanni Bucci) #54630
  • [1b81a7d003] - build: allow overriding clang usage (Shelley Vohr) #56016
  • [39c901307f] - build: remove defaults for create-release-proposal (Rafael Gonzaga) #56042
  • [7133c0459f] - build: avoid compiling with VS v17.12 (Stefan Stojanovic) #55930
  • [ce53f1689f] - build: set node_arch to target_cpu in GN (Shelley Vohr) #55967
  • [2023b09d27] - build: add create release proposal action (Rafael Gonzaga) #55690
  • [26ec99634c] - build: use variable for crypto dep path (Shelley Vohr) #55928
  • [f48e289580] - build: fix GN build for sqlite (Cheng) #55912
  • [fffabca6b8] - build: compile bundled simdutf conditionally (Jakub Jirutka) #55886
  • [d8eb83c5c5] - build: compile bundled simdjson conditionally (Jakub Jirutka) #55886
  • [83e02dc482] - build: compile bundled ada conditionally (Jakub Jirutka) #55886
  • [816d37a187] - (SEMVER-MINOR)cli: implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
  • [53c0f2f186] - crypto: ensure CryptoKey usages and algorithm are cached objects (Filip Skokan) #56108
  • [93d36bf1c8] - crypto: allow non-multiple of 8 in SubtleCrypto.deriveBits (Filip Skokan) #55296
  • [8680b8030c] - deps: update ngtcp2 to 1.9.1 (Node.js GitHub Bot) #56095
  • [78a2a6ca1e] - deps: upgrade npm to 10.9.2 (npm team) #56135
  • [52dfe5af4b] - deps: update sqlite to 3.47.1 (Node.js GitHub Bot) #56094
  • [3852b5c8d1] - deps: update zlib to 1.3.0.1-motley-82a5fec (Node.js GitHub Bot) #55980
  • [f99f95f62f] - deps: update corepack to 0.30.0 (Node.js GitHub Bot) #55977
  • [96e846de89] - deps: update ngtcp2 to 1.9.0 (Node.js GitHub Bot) #55975
  • [d180a8aedb] - deps: update simdutf to 5.6.3 (Node.js GitHub Bot) #55973
  • [288416a764] - deps: upgrade npm to 10.9.1 (npm team) #55951
  • [cf3f7ac512] - deps: update zlib to 1.3.0.1-motley-7e2e4d7 (Node.js GitHub Bot) #54432
  • [7768b3d054] - deps: update simdjson to 3.10.1 (Node.js GitHub Bot) #54678
  • [9c6103833b] - deps: update simdutf to 5.6.2 (Node.js GitHub Bot) #55889
  • [7b133d6220] - dgram: check udp buffer size to avoid fd leak (theanarkh) #56084
  • [e4529b8179] - doc: add report version and history section (Chengzhong Wu) #56130
  • [718625a03a] - doc: mention -a flag for the release script (Ruy Adorno) #56124
  • [59d6891872] - doc: add LJHarb to collaborators (Jordan Harband) #56132
  • [d7ed32404a] - doc: add create-release-action to process (Rafael Gonzaga) #55993
  • [3b4ef93371] - doc: rename file to advocacy-ambassador-program.md (Tobias Nießen) #56046
  • [59e4087d5e] - doc: add added tag and fix typo sqlite.md (Bart Louwers) #56012
  • [a1b26608ae] - doc: remove unused import from sample code (Blended Bram) #55570
  • [498f44ad73] - doc: add FAQ to releases section (Rafael Gonzaga) #55992
  • [d48348afaa] - doc: move history entry to class description (Luigi Pinca) #55991
  • [96926ce13c] - doc: add history entry for textEncoder.encodeInto() (Luigi Pinca) #55990
  • [e92d51d511] - doc: improve GN build documentation a bit (Shelley Vohr) #55968
  • [6be3824d6f] - doc: fix deprecation codes (Filip Skokan) #56018
  • [fa2b35d28d] - doc: remove confusing and outdated sentence (Luigi Pinca) #55988
  • [baed2763df] - doc: deprecate passing invalid types in fs.existsSync (Carlos Espa) #55892
  • [a3f7db6b6d] - doc: add doc for PerformanceObserver.takeRecords() (skyclouds2001) #55786
  • [770572423b] - doc: add vetted courses to the ambassador benefits (Matteo Collina) #55934
  • [98f8f4a8a9] - doc: order node:crypto APIs alphabetically (Julian Gassner) #55831
  • [1e0decb44c] - doc: doc how to add message for promotion (Michael Dawson) #55843
  • [ff48c29724] - doc: add esm example for zlib (Leonardo Peixoto) #55946
  • [ccc5a6d552] - doc: document approach for building wasm in deps (Michael Dawson) #55940
  • [c8bb8a6ac5] - doc: fix Node.js 23 column in CHANGELOG.md (Richard Lau) #55935
  • [9d078802ad] - doc: remove RedYetiDev from triagers team (Aviv Keller) #55947
  • [5a2a757119] - doc: add esm examples to node:timers (Alfredo González) #55857
  • [f711a48e15] - doc: fix relative path mention in --allow-fs (Rafael Gonzaga) #55791
  • [219f5f2627] - doc: include git node release --promote to steps (Rafael Gonzaga) #55835
  • [f9d25ed3e4] - doc: add history entry for import assertion removal (Antoine du Hamel) #55883
  • [efb9f05f59] - (SEMVER-MINOR)doc,lib,src,test: unflag sqlite module (Colin Ihrig) #55890
  • [a37e5fe5f8] - fs: lazily load ReadFileContext (Gürgün Dayıoğlu) #55998
  • [9289374248] - http2: fix memory leak caused by premature listener removing (ywave620) #55966
  • [49af1c33ac] - lib: add validation for options in compileFunction (Taejin Kim) #56023
  • [8faf91846b] - lib: fix fs.readdir recursive async (Rafael Gonzaga) #56041
  • [a2382303d7] - lib: refactor code to improve readability (Pietro Marchini) #55995
  • [30f26ba254] - lib: avoid excluding symlinks in recursive fs.readdir with filetypes (Juan José) #55714
  • [9b272ae339] - meta: bump github/codeql-action from 3.27.0 to 3.27.5 (dependabot[bot]) #56103
  • [fb0e6ca68b] - meta: bump actions/checkout from 4.1.7 to 4.2.2 (dependabot[bot]) #56102
  • [0ab611513c] - meta: bump step-security/harden-runner from 2.10.1 to 2.10.2 (dependabot[bot]) #56101
  • [ff4839b8ab] - meta: bump actions/setup-node from 4.0.3 to 4.1.0 (dependabot[bot]) #56100
  • [f262207356] - meta: add releasers as CODEOWNERS to proposal action (Rafael Gonzaga) #56043
  • [b6005b3fac] - module: mark evaluation rejection in require(esm) as handled (Joyee Cheung) #56122
  • [b8ab5332a9] - module: remove --experimental-default-type (Geoffrey Booth) #56092
  • [4be5047030] - module: do not warn when require(esm) comes from node_modules (Joyee Cheung) #55960
  • [c9698ed6a4] - (SEMVER-MINOR)net: support blocklist in net.connect (theanarkh) #56075
  • [9fba5e1df1] - (SEMVER-MINOR)net: add SocketAddress.parse (James M Snell) #56076
  • [565b04a7be] - (SEMVER-MINOR)net: add net.BlockList.isBlockList(value) (James M Snell) #56078
  • [30d604180d] - (SEMVER-MINOR)net: support blocklist for net.Server (theanarkh) #56079
  • [4cdb03201e] - (SEMVER-MINOR)process: deprecate features.{ipv6,uv} and features.tls_* (René) #55545
  • [d09e57b26d] - quic: update more QUIC implementation (James M Snell) #55986
  • [1fb30d6e86] - quic: multiple updates to quic impl (James M Snell) #55971
  • [9e4f7aa808] - sqlite: deps include sqlite3ext.h (Alex Yang) #56010
  • [d777d4a52d] - (SEMVER-MINOR)sqlite: add StatementSync.prototype.iterate method (tpoisseau) #54213
  • [66451bb9ba] - src: use spaceship operator in SocketAddress (James M Snell) #56059
  • [ad9ebe417a] - src: add missing qualifiers to env.cc (Yagiz Nizipli) #56062
  • [56c4da240d] - src: use std::string_view for process emit fns (Yagiz Nizipli) #56086
  • [26ab8e9823] - src: remove dead code in async_wrap (Gerhard Stöbich) #56065
  • [4dea44e468] - src: avoid copy on getV8FastApiCallCount (Yagiz Nizipli) #56081
  • [b778a4fe46] - src: fix check fd (theanarkh) #56000
  • [971f5f54df] - src: safely remove the last line from dotenv (Shima Ryuhei) #55982
  • [497a9aea1c] - src: fix kill signal on Windows (Hüseyin Açacak) #55514
  • [8a935489f9] - src,build: add no user defined deduction guides of CTAD check (Chengzhong Wu) #56071
  • [5edb8d5919] - test: remove test-fs-utimes flaky designation (Luigi Pinca) #56052
  • [046e642a80] - test: ensure cli.md is in alphabetical order (Antoine du Hamel) #56025
  • [da354f46cd] - test: update WPT for WebCryptoAPI to 3e3374efde (Node.js GitHub Bot) #56093
  • [9486c7ce4c] - test: update WPT for WebCryptoAPI to 76dfa54e5d (Node.js GitHub Bot) #56093
  • [a8809fc0f5] - test: move test-worker-arraybuffer-zerofill to parallel (Luigi Pinca) #56053
  • [6194435b9e] - test: update WPT for url to 67880a4eb83ca9aa732eec4b35a1971ff5bf37ff (Node.js GitHub Bot) #55999
  • [f7567d46d8] - test: make HTTP/1.0 connection test more robust (Arne Keller) #55959
  • [c157e026fc] - test: convert readdir test to use test runner (Thomas Chetwin) #55750
  • [29362ce673] - test: make x509 crypto tests work with BoringSSL (Shelley Vohr) #55927
  • [493e16c852] - test: fix determining lower priority (Livia Medeiros) #55908
  • [99858ceb9f] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #55997
  • [7c3a4d4bcd] - test_runner: refactor Promise chain in run() (Colin Ihrig) #55958
  • [95e8c4ef6c] - test_runner: refactor build Promise in Suite() (Colin Ihrig) #55958
  • [c048865199] - test_runner: simplify hook running logic (Colin Ihrig) #55963
  • [8197815fe8] - test_runner: mark snapshot testing as stable (Colin Ihrig) #55897
  • [8a5d8c7669] - test_runner: mark context.plan() as stable (Colin Ihrig) #55895
  • [790a2ca3b7] - tools: update create-release-proposal workflow (Antoine du Hamel) #56054
  • [98ce4652e2] - tools: fix update-undici script (Michaël Zasso) #56069
  • [d6a6c8ace1] - tools: allow dispatch of tools.yml from forks (Antoine du Hamel) #56008
  • [cc96fce5eb] - tools: fix nghttp3 updater script (Antoine du Hamel) #56007
  • [2cd939cb95] - tools: filter release keys to reduce interactivity (Antoine du Hamel) #55950
  • [4b3919f1be] - tools: update WPT updater (Antoine du Hamel) #56003
  • [54c46b8464] - tools: add WPT updater for specific subsystems (Mert Can Altin) #54460
  • [32b1681b7f] - tools: use tokenless Codecov uploads (Michaël Zasso) #55943
  • [475141e370] - tools: add linter for release commit proposals (Antoine du Hamel) #55923
  • [d093820f64] - tools: lint js in doc/**/*.md (Livia Medeiros) #55904
  • [72eb710f0f] - tools: fix riscv64 build failed (Lu Yahan) #52888
  • [882b70c83f] - tools: bump cross-spawn from 7.0.3 to 7.0.5 in /tools/eslint (dependabot[bot]) #55894
  • [9eccd7dba9] - util: add fast path for Latin1 decoding (Mert Can Altin) #55275

dependabotbotand others added 30 commits November 26, 2024 15:34
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.5. - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.5) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #55894 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #52888 Reviewed-By: Stewart X Addison <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #55883 Refs: #52104 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
The --shared-ada flag was introduced in #52924, but the implementation was incomplete. Resolves#52914 PR-URL: #55886 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
The --shared-simdjson flag was introduced in #52924, but the implementation was incomplete. Resolves#52914 PR-URL: #55886 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
The --shared-simdutf flag was introduced in #52924, but the implementation was incomplete. Resolves#52914 PR-URL: #55886 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #55889 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental. Fixes: #55854 PR-URL: #55890 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
This function does not require a CLI flag, does not emit a warning, and is a fairly simple API that is already being used heavily in the ecosystem. This commit marks context.plan() as stable. PR-URL: #55895 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
This commit marks the test runner's snapshot testing API as stable. PR-URL: #55897 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Refs: nodejs/node-core-utils#835 PR-URL: #55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #55791 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #55904 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Fixes: #42923 PR-URL: #55514 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
PR-URL: #55908Fixes: NixOS/nixpkgs#355919 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #55857 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #55912 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #54678 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #55947 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #54213 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #55927 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
The column for Node.js 23 in `CHANGELOG.md` is missing an opening `<td>` tag so was not correctly rendering. PR-URL: #55935 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55923 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Refs: nodejs/security-wg#1236 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #55940 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55928 Reviewed-By: Cheng Zhao <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
As part of the standard experimental feature graduation policy, when we unflagged require(esm) we moved the experimental warning to be emitted when require() is actually used to load ESM, which previously was an error. However, some packages in the ecosystem have already being using try-catch to load require(esm) to e.g. resolve optional dependency, and emitting warning from there instead of throwing directly could break the CLI output. To reduce the disruption for releases, as a compromise, this patch skips the warning if require(esm) comes from node_modules, where users typically don't have much control over the code. This warning will be eventually removed when require(esm) becomes stable. This patch was originally intended for the LTS releases, though it seems there's appetite for it on v23.x as well so it's re-targeted to the main branch. PR-URL: #55960 Refs: #55217 Refs: #52697 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: #55946 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #54432 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Document the process for adding a message that ambassadors will be asked to promote. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #55843 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
kimtaejin3and others added 4 commits December 6, 2024 15:26
PR-URL: #56023 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #56095 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #56130 Refs: #56068 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
targos added a commit that referenced this pull request Dec 6, 2024
Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc: * add LJHarb to collaborators (Jordan Harband) #56132 net: * (SEMVER-MINOR) add BlockList.isBlockList(value) (James M Snell) #56078 * (SEMVER-MINOR) support blockList in net.connect (theanarkh) #56075 * (SEMVER-MINOR) support blockList in net.Server (theanarkh) #56079 * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: #56119
@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2024
@targostargos changed the title 2024-12-04, Version 23.4.0 (Current), @targos2024-12-10, Version 23.4.0 (Current), @targosDec 6, 2024
@targos
Copy link
Member

Updated with new commits.

@ljharb Unfortunately I'm not aware of a way to make sure you are notified when the commit is backported.

@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2024
@nodejs-github-bot
Copy link
CollaboratorAuthor

@targos
Copy link
Member

@targos
Copy link
Member

10:40:18 Please update REPLACEME tags in the following doc/api/*.md files (See doc/contributing/releases.md):\n
10:40:18 doc/api/net.md\n

:( Not sure I'll have time to fix today. If someone from @nodejs/releasers wants to take over, be my guest!

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc: * add LJHarb to collaborators (Jordan Harband) #56132 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist in net.connect (theanarkh) #56075 * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076 * (SEMVER-MINOR) add net.BlockList.isBlockList(value) (James M Snell) #56078 * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: #56119
@aduh95aduh95 self-assigned this Dec 10, 2024
@aduh95
Copy link
Contributor

📦: https://ci-release.nodejs.org/job/iojs+release/10665/

@targos
Copy link
Member

⚠️lint-release-commit failed.

Btw, I forgot we had such a workflow. We should add the REPLACEME validation to it!

@aduh95
Copy link
Contributor

Fix is #56203, we can safely ignore the failure this time.

@joyeecheung
Copy link
Member

joyeecheung commented Dec 10, 2024

I see that there isn't a text for #55604 - not sure where is the best place to comment on it, but it should be something not to far away from the OP of that PR. If the examples in that OP are too long, it could be shortened into

This release introduces --trace-env, --trace-env-js-stack and --trace-env-native-stack CLI options that print information about any access to environment variables done in the current Node.js instance to stderr. Currently in the logs, only the names of the environment variables being accessed are printed, while the values are not printed to avoid leaking sensitive information. To print the stack trace of the access, use --trace-env-js-stack and/or --trace-env-native-stack.

@aduh95aduh95 merged commit e8cf3a6 into v23.xDec 10, 2024
21 of 22 checks passed
aduh95 added a commit that referenced this pull request Dec 10, 2024
Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc: * add LJHarb to collaborators (Jordan Harband) #56132 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist in net.connect (theanarkh) #56075 * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076 * (SEMVER-MINOR) add net.BlockList.isBlockList(value) (James M Snell) #56078 * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: #56119
@aduh95aduh95 deleted the v23.4.0-proposal branch December 10, 2024 15:37
aduh95 added a commit that referenced this pull request Dec 10, 2024
aduh95 added a commit to aduh95/nodejs.org that referenced this pull request Dec 10, 2024
github-merge-queuebot pushed a commit to nodejs/nodejs.org that referenced this pull request Dec 10, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releaseIssues and PRs related to Node.js releases.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@nodejs-github-bot@targos@ljharb@aduh95@joyeecheung@richardlau@luyahan@jirutka@cjihrig@RafaelGSS@LiviaMedeiros@huseyinacacak-janea@mfdebian@zcbenz@avivkeller@tpoisseau@codebytere@mhdawson@peixotoleonardo@panva