Skip to content

Conversation

@richardlau
Copy link
Member

Similar to node-test-pull-request, node-test-commit-v8-linux also now requires COMMIT_SHA_CHECK to be passed to it.

Refs: #911

Similar to `node-test-pull-request`, `node-test-commit-v8-linux` also now requires `COMMIT_SHA_CHECK` to be passed to it. Refs: nodejs#911
@codecov
Copy link

codecovbot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.22%. Comparing base (404c0ac) to head (031133c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #928 +/- ## ========================================== + Coverage 79.76% 80.22% +0.45%  ========================================== Files 39 39 Lines 4630 4631 +1 ========================================== + Hits 3693 3715 +22 + Misses 937 916 -21 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richardlau

This comment was marked as outdated.

Copy link
Member

@targostargos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no experience with writing tests in this repo.

@richardlau
Copy link
MemberAuthor

I gave up on trying to have different stub implementations and instead modified the stub for Formdata.prototype.append attempt to guess which set of parameters to expect and validate against.

@joyeecheungjoyeecheung merged commit 259da2a into nodejs:mainMay 22, 2025
15 checks passed
@richardlaurichardlau deleted the v8ci branch May 22, 2025 10:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The CI task 'node-test-commit-v8-linux' fails sometimes

3 participants

@richardlau@targos@joyeecheung