src: use String::WriteV2() in TwoByteValue

[tniessen]

Since String::Write() is deprecated, use String::WriteV2() instead.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (6de55f7) to head (eb4a606).
Report is 306 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #58164 +/- ## ======================================= Coverage 90.17% 90.18% ======================================= Files 630 630 Lines 186503 186502 -1 Branches 36614 36612 -2 ======================================= + Hits 168187 168200 +13 + Misses 11124 11116 -8 + Partials 7192 7186 -6 

Files with missing lines	Coverage Δ
src/util.cc	86.86% <100.00%> (-0.03%)	⬇️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66603/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/58164 ✔ Done loading data for nodejs/node/pull/58164 ----------------------------------- PR info ------------------------------------ Title src: use String::WriteV2() in TwoByteValue (#58164) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:src-twobytevalue-writev2 -> nodejs:main Labels c++, v8 engine, author ready, needs-ci Commits 1 - src: use String::WriteV2() in TwoByteValue Committers 1 - Tobias Nießen <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58164 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58164 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 04 May 2025 15:34:31 GMT ✔ Approvals: 6 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/58164#pullrequestreview-2813498914 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/58164#pullrequestreview-2813505928 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/58164#pullrequestreview-2813533305 ✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/58164#pullrequestreview-2813696863 ✔ - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/58164#pullrequestreview-2815817883 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58164#pullrequestreview-2820020780 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-05-05T03:04:00Z: https://ci.nodejs.org/job/node-test-pull-request/66603/ - Querying data for job/node-test-pull-request/66603/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/14913152558

[tniessen]

@nodejs/build I am not sure why the commit queue says "Last GitHub CI failed", nor do I know what's up with the failed node-test-commit-v8-linux.

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6546/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6546/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6546/

[richardlau]

nor do I know what's up with the failed node-test-commit-v8-linux.

https://ci.nodejs.org/job/node-test-commit-v8-linux/6529/ was started by the automation because this PR was labelled v8 engine, and failed because ncu-ci from node-core-utils is not setting COMMIT_SHA_CHECK when starting the job. It's a one line fix (but I'm struggling with writing a unit test for it in the existing framework): nodejs/node-core-utils#928

https://ci.nodejs.org/job/node-test-commit-v8-linux/6545/ failed because the COMMIT_SHA_CHECK parameter did not match the SHA of the head commit of this pull request. I submitted https://ci.nodejs.org/job/node-test-commit-v8-linux/6546/ with the correct value for the parameter.

[nodejs-github-bot]

Landed in 8debf0b

[tniessen]

Thank you @richardlau!

[aduh95]

Adding dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x. as it looks like WriteV2 is not available on 22.x.