deps: ICU 58.2 bump

[srl295]

Checklist

• make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

deps

Description of change

No feature changes. Bug fixes.

Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

• CLDR 30.0.3 ( was 30.0.2)
• Timezone 2016j ( was 2016g )

[srl295]

Note: actual impact is smaller than what's here due to whitespace when it actually lands. I'll see if I can figure out how to reduce the whitespace churn here.

Guess i need to 'land' the PR on a branch with am … fix-whitespace .. and force push that branch back

[srl295]

58.2 was released http://site.icu-project.org/download/58

[Fishrock123]

Sorry about that.

@srl295 should this be backported to LTS?

[mhdawson]

Removing the whitespace changes would make it a lot easier to review.

[srl295]

@Fishrock123 yes, i think it should be backported
@mhdawson try it now - should be a lot easier to review.

I used curl -L https://github.com/nodejs/node/pull/10206.patch | git am --whitespace=fix to "land" it on a new branch, the pushed that back. Is there an easier way to do this? If I can integrate it into the "howto upgrade ICU docs", we can make this the same way for the future.

[mhdawson]

LGTM

[Fishrock123]

CI: https://ci.nodejs.org/job/node-test-pull-request/5443/

[gibfahn]

@mhdawson To review without the whitespace changes you can just add ?w=1 to the end of the URL.

@srl295 I think fixing the whitespace issues is the right way to go, if people find it messy they can use the ?w=1 trick. Obviously hopefully once the issues have been fixed once then it won't continue to be a problem.

[srl295]

White space is always fixed when landing. So the issue is only around review. I've already pushed a commit that fixes whitespace

[jasnell]

CI : https://ci.nodejs.org/job/node-test-pull-request/5606/

[srl295]

landed in 68f004f and c830179