deps: v6.x backport of #9234/#10206 bump ICU to 58.2 🍒 #10887
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* bump to ICU 58.1 - update URL / hash * does not attempt to reduce size - yet * patch to work around http://bugs.icu-project.org/trac/ticket/12822 ( compile issue on Windows) * Fix ICU shrinker to delete old license.html file (update to nodejs#8674 ) Fixes: nodejs#7844 PR-URL: nodejs#9234 Reviewed-By: James M Snell <[email protected]>
This commit contains the ICU 58.1 delta. It is especially large because of the ICU license change, and, because the line endings were off previously. * bump to ICU 58.1 - check in small ICU source * from 58.1 final http://site.icu-project.org/download/58Fixes: nodejs#7844 PR-URL: nodejs#9234 Reviewed-By: James M Snell <[email protected]>
Bump ICU from 58.1 to 58.2 No feature changes. Bug fixes. * This commit contains the actual ICU source code and data. * CLDR 30.0.3 ( was 30.0.2) * Timezone 2016j ( was 2016g ) ICU Details: http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2 PR-URL: nodejs#10206 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Bump configure download path for ICU from 58.1 to 58.2 * This commit just changes the download URL. PR-URL: nodejs#10206 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot added build 
srl295 changed the title srl295 changed the title 
MemberAuthor
srl295 commented Jan 19, 2017
Builts/tests OK on RHEL. On mac, I get this failure even on |
Contributor
MylesBorins commented Jan 19, 2017 via email
which version of osx? I've been testing without issue on 10.10.x …On Wed, Jan 18, 2017, 9:52 PM Steven R. Loomis ***@***.***> wrote: Builts/tests OK on RHEL. On mac, I get this failure even on v6.x-staging https://gist.github.com/srl295/1218d5b47639da248a79e21bb21e99d1 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#10887 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecVyL_LbK-KkRPCWdrPOWTDM5V0Ohwks5rTtAFgaJpZM4LnmxT> . |
Contributor
MylesBorins commented Jan 19, 2017
MemberAuthor
srl295 commented Jan 20, 2017
Do i need to change the commit message besides the PR URL? |
Contributor
MylesBorins commented Jan 20, 2017
landed in abff416...d51c637 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
deps: ICU bump