doc: restrict the ES.Next features usage in tests#11452
Uh oh!
There was an error while loading. Please reload this page.
Conversation
DavidCai1111 commented Feb 18, 2017
i5ting commented Feb 18, 2017
nice job |
doc/guides/writing-tests.md Outdated
There was a problem hiding this comment.
May be s/v4.x/all maintained branches for timelessness. (we can add a link to https://github.com/nodejs/lts to explain what are those maintained branches)
There was a problem hiding this comment.
Also we can add a link to the upcoming backporting guide to the backporting part, doesn't need to happen in this PR though. Pending PR: #11099
DavidCai1111 commented Feb 18, 2017
@joyeecheung Updated, PTAL. |
doc/guides/writing-tests.md Outdated
There was a problem hiding this comment.
The lts project link should have a text. Maybe [the LTS page](https://github.com/nodejs/lts).
Also nit: 80-character wrap.
There was a problem hiding this comment.
Actuallyall maintained branches is probably clear enough(no need for the lts/v4.x part). The lts link can be attached to this phrase and the node.green tip can be placed in the parens.
There was a problem hiding this comment.
Oh uh..by s/v4.x/all maintained branches/ I meant "replace v4.x with all maintained branches"(sed syntax). Sorry for not being clear.
There was a problem hiding this comment.
Thanks for the correction, so "for the ease of backporting, it is encouraged to use those ES.Next features that can be used directly without a flag in [all maintained branches](https://github.com/nodejs/lts), you can check [node.green](http://node.green) for all available features in each release." will be better?
joyeecheung commented Feb 18, 2017
@Trott might want to take a look at this? |
Trott commented Feb 19, 2017
@nodejs/testing Seems A-OK to me. |
joyeecheung commented Feb 21, 2017
Landed in 88035bc, thanks! |
PR-URL: #11452 Refs: #11290 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #11452 Refs: #11290 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell commented Mar 7, 2017
this would need a backport pr to land in v6 or v4 |
PR-URL: nodejs#11452 Refs: nodejs#11290 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
DavidCai1111 commented Mar 7, 2017
MylesBorins commented Mar 8, 2017
@DavidCai1993 I'm noticing a backport to v4.x with a conflict, but no backport to v6.x. Would you be able to do v6 too? |
DavidCai1111 commented Mar 8, 2017
@MylesBorins Sure 😄 |
DavidCai1111 commented Mar 8, 2017
@MylesBorins PR for v6.x: #11743 |
PR-URL: #11452 Refs: #11290 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #11452 Refs: #11290 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs/node#11452 Refs: nodejs/node#11290 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
9 participants
Update the
writing-testsguide to restrict the ES.Next features usage in tests for the ease of backporting (only encourage to use those features that can be used directly without a flag inall maintained branches) .Refs: #11290
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc