Skip to content

Conversation

@DavidCai1111
Copy link
Member

Backport of #11452 to v4.x.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

PR-URL: nodejs#11452 Refs: nodejs#11290 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. v4.x labels Mar 7, 2017
@hiroppyhiroppy added the test Issues and PRs related to the tests. label Mar 7, 2017
@MylesBorins
Copy link
Contributor

This is not landing due to a conflict, and as we are not likely to do another v4 release before going into maintenance mode I'm closing this

Thanks for the backport

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@DavidCai1111@MylesBorins@hiroppy@nodejs-github-bot@davidtaikocha