inspector: proper WS URLs when bound to 0.0.0.0#11850
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
ContributorAuthor
eugeneo commented Mar 14, 2017
@italoacasas - I am not sure how to create backporting pull requests, please advise. |
bnoordhuis approved these changes Mar 14, 2017
ContributorAuthor
eugeneo commented Mar 14, 2017
@eugeneo you did it great. Thank you |
italoacasas approved these changes Mar 14, 2017
jasnell approved these changes Mar 14, 2017
JSON target list response will now return appropriate IP address for instances listening on 0.0.0.0. Backport of #11755 PR-URL: #11850 Refs: #11591 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: James Snell <[email protected]>
cjihrig added a commit that referenced this pull request Mar 21, 2017
cjihrig added a commit that referenced this pull request Mar 21, 2017
Contributor
MylesBorins commented Apr 17, 2017
similar to other inspector stuff. Any chance of a mass backport? |
imyller added a commit to imyller/meta-nodejs that referenced this pull request Apr 20, 2017
Notable changes: * deps: Add node-inspect 1.10.6 (Jan Krems) nodejs/node#11869 * inspector: proper WS URLs when bound to 0.0.0.0 (Eugene Ostroukhov) nodejs/node#11850 * tls: fix segfault on destroy after partial read. (Ben Noordhuis) nodejs/node#11898 PR-URL: nodejs/node#11941 Signed-off-by: Ilkka Myller <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON target list response will now return appropriate IP address
for instances listening on 0.0.0.0.
Refs: #11591
PR-URL: #11755
Reviewed-By: James Snell [email protected]
Reviewed-By: Ben Noordhuis [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
inspector: IP is not obtained from the socket
This is a backport of #11755. The only change is that the test now checks if common.skipIfInspectorDisabled exists before calling it.