Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
deps: Add node-inspect 1.10.6#11869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
hybrist commented Mar 15, 2017 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
This updates the bundled `node-inspect` to 1.10.6. Highlights: * `node --debug-port=1234 inspect` respects the custom port. * Test stability improvements on various platforms. Compare: nodejs/node-inspect@v1.10.4...v1.10.6
hybrist commented Mar 15, 2017
Previous PR: #10187 Changeset generated via: rm -rf deps/node-inspect node-inspect-*&& curl -sSL "https://github.com/nodejs/node-inspect/archive/v1.10.6.tar.gz"| tar -xzvf - && mv node-inspect-* deps/node-inspect |
hybrist commented Mar 15, 2017
One test fails because of https://github.com/nodejs/node/pull/6171/files#r106263519 - |
lib/internal/bootstrap_node.js Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hack appear in multiple places in bootstrap. What I saw before adding it: The pingPort function calls net.connect and setTimeout. Unless the latter was removed or moved to the next tick, none of the connect events would ever fire.
addaleax left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamp-ish LGTM (lib: might be a better subsystem for the second commit, though)
7f0e833 to 43bd1dbComparehybrist commented Mar 15, 2017 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
|
hybrist commented Mar 15, 2017
Since |
Trott left a comment • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamp LGTM if CI is ✅
jasnell left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp LGTM here as well. Tried it out and it appears to work as expected :-)
hybrist commented Mar 16, 2017
I think my force-push to reword the commit is why those CI builds failed ( |
jasnell commented Mar 17, 2017
hybrist commented Mar 17, 2017
🍏 |
This updates the bundled `node-inspect` to 1.10.6. Highlights: * `node --debug-port=1234 inspect` respects the custom port. * Test stability improvements on various platforms. Compare: nodejs/node-inspect@v1.10.4...v1.10.6 PR-URL: #11869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #11869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell commented Mar 17, 2017
Landed in b57f9ee...7042631 |
PR-URL: nodejs#11869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This updates the bundled `node-inspect` to 1.10.6. Highlights: * `node --debug-port=1234 inspect` respects the custom port. * Test stability improvements on various platforms. Compare: nodejs/node-inspect@v1.10.4...v1.10.6 PR-URL: nodejs#11869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This updates the bundled `node-inspect` to 1.10.6. Highlights: * `node --debug-port=1234 inspect` respects the custom port. * Test stability improvements on various platforms. Compare: nodejs/node-inspect@v1.10.4...v1.10.6 PR-URL: nodejs#11869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#11869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This updates the bundled
node-inspectto 1.10.6.Highlights
node --debug-port=1234 inspectrespects the custom port.Compare: nodejs/node-inspect@v1.10.4...v1.10.6
Rendered Changelog
Checklist
make test-node-inspectpassesAffected core subsystem(s)
node-inspect