Skip to content

Conversation

@hybrist
Copy link
Contributor

@hybristhybrist commented Mar 15, 2017

This updates the bundled node-inspect to 1.10.6.

Highlights

  • node --debug-port=1234 inspect respects the custom port.
  • Test stability improvements on various platforms.

Compare: nodejs/node-inspect@v1.10.4...v1.10.6

Rendered Changelog

1.10.6

  • chore: Fix usage text for embedded mode - @addaleax#20
    • b0779f5chore: Fix usage text for embedded mode
  • print 'ok' after connection - @ofrobots#25
    • 2a47125fix: print 'ok' after connection
  • Make autocompletion in REPL work - @aqrln#28
    • ccab737fix: Make autocompletion in REPL work
  • Remove console.error() statement - @aqrln#30
    • 032b045style: Remove console.error() statement
  • Take --debug-port into account - @jkrems#26
    • 054d4b1fix: Take --debug-port into account
  • Delay run until breakpoints are restored - @jkrems#34
    • 802b88cfix: Delay run until breakpoints are restored
    • 2b93173fix: Use single string for paused notice
    • b4d5ee2fix: Work around inconsistent handling of strict directive
    • f6ccfc7fix: Only restart after port is free
    • 8b101bftest: Skip exact match on AIX
  • a4e4b6fchore: Fix repo info in package.json

1.10.5

  • docs: minor edits to governance docs - @joshgav#17
    • a70fe04docs: minor edits to governance docs
Checklist
  • make test-node-inspect passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

node-inspect

This updates the bundled `node-inspect` to 1.10.6. Highlights: * `node --debug-port=1234 inspect` respects the custom port. * Test stability improvements on various platforms. Compare: nodejs/node-inspect@v1.10.4...v1.10.6
@hybrist
Copy link
ContributorAuthor

Previous PR: #10187

Changeset generated via:

rm -rf deps/node-inspect node-inspect-*&& curl -sSL "https://github.com/nodejs/node-inspect/archive/v1.10.6.tar.gz"| tar -xzvf - && mv node-inspect-* deps/node-inspect

@hybrist
Copy link
ContributorAuthor

One test fails because of https://github.com/nodejs/node/pull/6171/files#r106263519 - <enter> is swallowed inside of repl.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hack appear in multiple places in bootstrap. What I saw before adding it: The pingPort function calls net.connect and setTimeout. Unless the latter was removed or moved to the next tick, none of the connect events would ever fire.

Copy link
Member

@addaleaxaddaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp-ish LGTM (lib: might be a better subsystem for the second commit, though)

CI: https://ci.nodejs.org/job/node-test-commit/8488/

@hybristhybristforce-pushed the node-inspect-1.10.6 branch from 7f0e833 to 43bd1dbCompareMarch 15, 2017 22:41
@hybrist
Copy link
ContributorAuthor

hybrist commented Mar 15, 2017

s/deps:/lib: for that second commit message. Guess I went with deps: because I was still thinking about merging the two commits while writing the commit message. Thanks for clarifying! 👍

@hybrist
Copy link
ContributorAuthor

Since make test-node-inspect doesn't pass on master right now, I backed that bullet point out of the issue description (working on making them pass again in parallel).

Copy link
Member

@TrottTrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM if CI is ✅

Copy link
Member

@jasnelljasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM here as well. Tried it out and it appears to work as expected :-)

@hybrist
Copy link
ContributorAuthor

I think my force-push to reword the commit is why those CI builds failed (Could not checkout 7f0e8337eaf1198a9f23a2de25d2b9418800f84e).

@jasnell
Copy link
Member

@hybrist
Copy link
ContributorAuthor

🍏

jasnell pushed a commit that referenced this pull request Mar 17, 2017
This updates the bundled `node-inspect` to 1.10.6. Highlights: * `node --debug-port=1234 inspect` respects the custom port. * Test stability improvements on various platforms. Compare: nodejs/node-inspect@v1.10.4...v1.10.6 PR-URL: #11869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 17, 2017
PR-URL: #11869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@jasnell
Copy link
Member

Landed in b57f9ee...7042631

@jasnelljasnell closed this Mar 17, 2017
@hybristhybrist deleted the node-inspect-1.10.6 branch March 17, 2017 18:09
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 20, 2017
PR-URL: nodejs#11869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 20, 2017
This updates the bundled `node-inspect` to 1.10.6. Highlights: * `node --debug-port=1234 inspect` respects the custom port. * Test stability improvements on various platforms. Compare: nodejs/node-inspect@v1.10.4...v1.10.6 PR-URL: nodejs#11869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@italoacasasitaloacasas mentioned this pull request Mar 20, 2017
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
This updates the bundled `node-inspect` to 1.10.6. Highlights: * `node --debug-port=1234 inspect` respects the custom port. * Test stability improvements on various platforms. Compare: nodejs/node-inspect@v1.10.4...v1.10.6 PR-URL: nodejs#11869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
PR-URL: nodejs#11869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
cjihrig added a commit that referenced this pull request Mar 21, 2017
Notable changes: * deps: Add node-inspect 1.10.6 (Jan Krems) #11869 * inspector: proper WS URLs when bound to 0.0.0.0 (Eugene Ostroukhov) #11850 * tls: fix segfault on destroy after partial read. (Ben Noordhuis) #11898 PR-URL: #11941
cjihrig added a commit that referenced this pull request Mar 21, 2017
Notable changes: * deps: Add node-inspect 1.10.6 (Jan Krems) #11869 * inspector: proper WS URLs when bound to 0.0.0.0 (Eugene Ostroukhov) #11850 * tls: fix segfault on destroy after partial read. (Ben Noordhuis) #11898 PR-URL: #11941
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@hybrist@jasnell@Trott@addaleax@cjihrig@mscdex@MylesBorins