src: make PercentDecode return void#11922
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
TimothyGu added c++ 
nodejs-github-bot added c++ MemberAuthor
TimothyGu commented Mar 19, 2017
bnoordhuis approved these changes Mar 19, 2017
cjihrig approved these changes Mar 19, 2017
joyeecheung approved these changes Mar 20, 2017
src/node_url.h Outdated
Member
There was a problem hiding this comment.
Aside: c in the else block above is casted twice.
jasnell approved these changes Mar 20, 2017
It only returns 0, nor is it likely to have any error conditions in the future. PR-URL: nodejs#11922 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
TimothyGuforce-pushed the url-percent-void branch from 2c4df78 to d231236CompareMemberAuthor
TimothyGu commented Mar 22, 2017
Landed in d231236. |
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
It only returns 0, nor is it likely to have any error conditions in the future. PR-URL: #11922 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It only returns 0, nor is it likely to have any error conditions in the future.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src, url