V7.8.0 proposal#12104

MylesBorins · 2017-03-28T23:47:24Z

2017-03-28, Version 7.8.0 (Current), @MylesBorins

Notable Changes

buffer:
- do not segfault on out-of-range index (Timothy Gu) #11927
crypto:
- Fix memory leak if certificate is revoked (Tom Atkinson) #12089
deps:
- upgrade npm to 4.2.0 (Kat Marchán) #11389
- fix async await desugaring in V8 (Michaël Zasso) #12004
readline:
- add option to stop duplicates in history (Danny Nemer) #2982

Commits

[51c8d8088a] - Partial revert "tls: keep track of stream that is closed" (Trevor Norris) #11947
[751c1153a4] - benchmark: check end() argument to be > 0 (Vse Mozhet Byt) #12030
[210250465a] - benchmark: update obsolete information pointer (Rich Trott) #12026
[7aeeee3276] - benchmark: repair the fs/readfile benchmark (Sorin Baltateanu) #7818
[90acb773be] - benchmark: allow multiple values for same config (Nikolai Vavilov) #11819
[2f4ad6fea2] - benchmark: harmonize progress bar + stderr output (Vse Mozhet Byt) #11925
[d62ddbe145] - benchmark: fix fs\bench-realpathSync.js (Vse Mozhet Byt) #11904
[85eb1bc0a9] - benchmark: remove v8ForceOptimization calls (Lucas Lago) #11908
[17d16e8f3d] - buffer: remove unneeded eslint-disable comment (Rich Trott) #11906
[fb41ee3983] - build: add lint option to vcbuild.bat help (Morgan Brenner) #11992
[3e4ecca0be] - build: don't create directory for NDK toolchain (TheBeastOfCaerbannog) #11916
[a64aa442c1] - crypto: fix memory leak if certificate is revoked (Tom Atkinson) #12089
[2767e2d3cc] - (SEMVER-MINOR)deps: upgrade npm to 4.2.0 (Kat Marchán) #11389
[d22346de40] - deps: fix async await desugaring in V8 (Michaël Zasso) #12004
[fade55b025] - doc: clarify out-of-bounds behavior of buf[index] (Nikolai Vavilov) #11286
[63a19c7012] - doc: update and modernize examples in fs.ms (Vse Mozhet Byt) #12035
[4b5f177e3d] - doc: fix https.timeout docs (Ahmad Nassri) #12039
[af051f6528] - doc: fix http properties documented as methods (Ahmad Nassri) #12039
[18a586a278] - doc: edit the benchmark guide (Rich Trott) #12041
[5e3d429613] - doc: stdout/err/in are all Duplex streams (Sebastian Van Sande) #11194
[7f6b03fd0f] - doc: fix process.stdout fd number (Fumiya KARASAWA) #12055
[1f7fe55c97] - doc: add richardlau to collaborators (Richard Lau) #12020
[924f34606d] - doc: update collaborator email address (Rich Trott) #11996
[41bec5cff4] - doc: correct info in child_process.md (Vse Mozhet Byt) #11949
[96ad336d9e] - doc: remove superfluous sample assert code (Rich Trott) #11933
[486bd1bd9b] - doc: require uses fs root for '/' prefix (Bradley Farias) #11897
[04fa28e6dc] - doc: fix gitter badge in README (Roman Reiss) #11944
[68b23be51f] - doc: add missing word in stream.md (Jyotman Singh) #11914
[0f2642ee36] - errors: remove needless lazyAssert (DavidCai) #11891
[5bdd54925a] - lib: add comment to script eval _tickCallback (Gibson Fahnestock) #12050
[7347860966] - lib: clarify the usage of 'else' (Jackson Tian) #11148
[837ff4ba59] - lib: remove an unnecessary coverage check (Jeremiah Senkpiel) #12023
[6c803db7b9] - lib: fix event race condition with -e (Ben Noordhuis) #11958
[ac92d0249b] - net: refactor net module to module.exports (Claudio Rodriguez) #11698
[2462fd8009] - process: maintain constructor descriptor (Bryan English) #9306
[91a2700721] - readline: rename deDupeHistory option (Danny Nemer) #11950
[8ab26cf508] - (SEMVER-MINOR)readline: add option to stop duplicates in history (Danny Nemer) #2982
[6a6c431eec] - src: use persistent strings from node::Environment (Ben Noordhuis) #11945
[d0c2d67083] - src: add native URL class (James M Snell) #11801
[019a20adb5] - src: make PercentDecode return void (Timothy Gu) #11922
[d6da1705cd] - src: ensure that fd 0-2 are valid on windows (Bartosz Sosnowski) #11863
[59f71f5661] - src, buffer: do not segfault on out-of-range index (Timothy Gu) #11927
[4051184106] - stream_base,tls_wrap: notify on destruct (Trevor Norris) #11947
[d8b71be183] - test: fix misleading comment (Franziska Hinkelmann) #12048
[8b2b93f148] - test: mark child-process-exec-kill-throws flaky (Gibson Fahnestock) #12054
[948b99deab] - test: fix broken tests in test-buffer-includes (Alexey Orlenko) #12040
[d112aad78b] - test: replace throw with common.fail (Dejon "DJ" Gill) #9700
[41284fbc5b] - test: cover thrown errors from exec() kill (cjihrig) #11038
[414df6c93b] - test: test validity of prefix in mkdtempSync (Luca Maraschi) #12009
[1c0435b1f3] - test: add regex for expected error message (John F. Mercer) #12011
[a73dea9499] - test: add second argument to assert.throws() (Rj Bernaldo) #12016
[ade64e61cd] - test: refactor test-cluster-disconnect (Rich Trott) #11981
[3d21bfe6b9] - test: invalid chars in http client path (Luca Maraschi) #11964
[e70ed3cb31] - test: improve test-vm-cached-data.js (Nick Peleh) #11974
[b48f13af95] - test: add minimal test for net benchmarks (Rich Trott) #11979
[764a00e6e5] - test: add test for url (Yuta Hiroto) #11999
[bb2de4a5a1] - test: do not use more command on Windows (Vse Mozhet Byt) #11953
[55a112689a] - test: add test for child_process.execFile() (Rich Trott) #11929
[9ba551f7e3] - test: fix flaky test-tls-socket-close (Rich Trott) #11921
[114f9d619d] - test: add hasCrypto check to tls-socket-close (Daniel Bevenius) #11911
[169f187f16] - test: synchronize WPT url setters tests data (Daijiro Wachi) #11887
[4b1b6b85a9] - timers: fix not to close reused timer handle (Shigeki Ohtsu) #11646
[fd93622f8a] - tls: fix SecurePair external memory reporting (Ben Noordhuis) #11896
[126dcb76af] - url: name anonymous functions in url (Pedro lima) #9225
[f6755182e5] - url: show input in parse error message (Joyee Cheung) #11934
[c51d925c84] - url: restrict setting protocol to "file" (Daijiro Wachi) #11887

This is a backport of https://codereview.chromium.org/2672313003/. The patch did not land in V8 because it was superseded by another one but it is much easier to backport to V8 5.5, was reviewed and passed tests. Original commit message: [async await] Fix async function desugaring Previously we rewrote the return statement in an async function from `return expr;` to `return %ResolvePromise(.promise, expr), .promise`. This can lead to incorrect behavior in the presence of try-finally. This patch stores the `expr` of the return statement in a temporary variable, resolves and returns the promise at the end of the finally block. BUG=v8:5896 PR-URL: #12004Fixes: #11960 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

lib/buffer.js uses a function declaration for `Buffer`. So it never uses an instance of `Buffer` in the global scope. Therefore the disabling of the `require-buffer` custom rule is not needed. Remove the comment. PR-URL: #11906 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

Adds `options.deDupeHistory` for `readline.createInterface(options)`. If `options.deDupeHistory` is `true`, when a new input line being added to the history list duplicates an older one, removes the older line from the list. Defaults to `false`. Many users would appreciate this option, as it is a common setting in shells. This option certainly should not be default behavior, as it would be problematic in applications such as the `repl`, which inherits from the readline `Interface`. Extends documentation to reflect this API addition. Adds tests for when `options.deDupeHistory` is truthy, and when `options.deDupeHistory` is falsey. PR-URL: #2982 Reviewed-By: Jeremiah Senkpiel <[email protected]>

Since file URLs can not have `username/password/port`, the specification was updated to restrict setting protocol to "file". Refs: whatwg/url#269Fixes: #11785 PR-URL: #11887 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

Synchronize url-setter-test to upstream. Refs: web-platform-tests/wpt#5112 PR-URL: #11887 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

PR-URL: #11914Fixes: #11913 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>

Check that stdin, stdout and stderr are valid file descriptors on Windows. If not, reopen them with 'nul' file. Refs: #875Fixes: #11656 PR-URL: #11863 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

GitHub now renders Markdown in CommonMark where spaces in a link destination are invalid and need to be escaped. PR-URL: #11944 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

Currently test-tls-socket-close will fail if node was built using --without-ssl. This commit adds a check to verify is crypto support exists and if not skip this test. PR-URL: #11911 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

This removes common.v8ForceOptimization calls from url and vm benchmark files. PR-URL: #11908Fixes: #11895 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Make it call-site-cwd-independent. PR-URL: #11904 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

It only returns 0, nor is it likely to have any error conditions in the future. PR-URL: #11922 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Replace timer/timeout race with event-based ordering, eliminating test flakiness. PR-URL: #11921Fixes: #11912 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]>

While `child_process.execFile()` gets called in places in the test suite, there are no explicit test for it and there are parts of the implementation that are not covered by tests. This adds a minimal test that increases (but does not complete) coverage for the implementation. PR-URL: #11929 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>

Also add test cases for partial writes and invalid indices. PR-URL: #11927Fixes: #8724 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Add a space for minimal readability. PR-URL: #11925 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Let make-standalone-toolchain.sh create directory. PR-URL: #11916 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>

PR-URL: #11897Fixes: #7151 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

PR-URL: #11891 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

Remove superfluous sample code. Since `assert()` is documented as an alias of `assert.ok()` and nothing more, the sample code for `assert.ok()` is sufficient. PR-URL: #11933 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>

Adds a URL native class for use within the node.js c/c++ code. This is primarily intended to be used by the eventual ES6 modules implementation but can be used generally wherever URL parsing within the c/c++ may be necessary. ```c URL url1("http://example.org"); URL url2("foo", "http://example.org/bar"); URL url3("baz", &url2); ``` While we're at it, reduce reliance on macros to simplify impl. PR-URL: #11801 Reviewed-By: Anna Henningsen <[email protected]>

Renames `options.deDupeHistory` → `options.removeHistoryDuplicates` for `readline.createInterface(options)`. The option name `removeHistoryDuplicates` is preferable to the semantically identical name `deDupeHistory` because "dedupe" (short for "deduplication") is obscure and neologistic while `removeHistoryDuplicates` is clear, though verbose. Updates tests and documentation for this option accordingly. PR-URL: #11950 Ref: #2982 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>

`child.stderr`, `child.stdin`, and `child.stdout` are `null`, not `undefined`, if the relevant `stdio` properties are set to anything other than 'pipe'. PR-URL: #11949 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>

Replace a few calls to FIXED_ONE_BYTE_STRING() with their persistent counterparts from `node::Environment`. None of the calls are in hot code paths but why create a new string when one already exists? PR-URL: #11945 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Brian White <[email protected]>

This allows running a benchmark with two or more values for the same config rather than just one or all of them, for example: ``` node benchmark/buffers/buffer-creation.js type=buffer() type=fast-alloc type=fast-alloc-fill ``` PR-URL: #11819 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Brian White <[email protected]>

The timer handle is reused when it is unrefed in order to avoid new callback in beforeExit(#3407). If it is unrefed within a setInterval callback, the reused timer handle is closed so that setInterval no longer keep working. This fix does not close the handle in case of setInterval. PR-URL: #11646 Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>

PR-URL: #11389 Reviewed-By: Jeremiah Senkpiel <[email protected]>

Per email conversation with Shigeki Ohtsu, updating email address in docs. The current listed email address does not work anymore. PR-URL: #11996 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>

PR-URL: #11953Fixes: #11469 Reviewed-By: João Reis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: #11934 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

The comment is outdated, function declarations have nothing to do with defineProperties. PR-URL: #12048 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>

The additional validity checks applied to StartCom and WoSign certificates failed to free memory before returning. Refs: #9469Fixes: #12033 PR-URL: #12089 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Ensure that AdjustAmountOfExternalAllocatedMemory() is called when the SecurePair is destroyed. Not doing so is not an actual memory leak but it makes `process.memoryUsage().external` wildly inaccurate and can cause performance problems due to excessive garbage collection. PR-URL: #11896 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Add a comment to match lib/module.js, missed in #11958. PR-URL: #12050 Ref: #11958 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Richard Lau <[email protected]>

MylesBorins · 2017-03-28T23:49:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/7076/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/675/

edit:

heres a run of 7.x on linux to check out the unexpected clang failure:

https://ci.nodejs.org/job/node-test-commit-linux/8737/

looks like the same executor is failing on v7.7.x. Based on this I'm going to sign off on the CI being good.

citgm failures:

windows build failure unrelated
rhel72 failure of spdy is timeout
ubuntu 1604 failure of readable-stream is expected due to environment issue

Citgm looks good 🎉

MylesBorins · 2017-03-28T23:50:28Z

/cc @nodejs/collaborators can you all put eyes on this ASAP please. We want to get this release out before end of day

addaleax · 2017-03-28T23:53:18Z

[d0c2d67] - (SEMVER-MINOR) src: add native URL class (James M Snell) #11801

That’s not semver-minor because it’s only about internals, I’ve pulled the label from the PR too.

Seems good to me otherwise!

Notable changes: * buffer: - do not segfault on out-of-range index (Timothy Gu) #11927 * crypto: - Fix memory leak if certificate is revoked (Tom Atkinson) #12089 * deps: * upgrade npm to 4.2.0 (Kat Marchán) #11389 * fix async await desugaring in V8 (Michaël Zasso) #12004 * readline: - add option to stop duplicates in history (Danny Nemer) #2982 * src: - add native URL class (James M Snell) #11801 PR-URL: #12104

italoacasas · 2017-03-28T23:55:08Z

Everything looks good.

mscdex · 2017-03-29T00:15:04Z

There is a strange compilation failure on one of the Linux machines.

The error is:

 clang++ '-DV8_TARGET_ARCH_X64' '-DENABLE_DISASSEMBLER' '-DV8_I18N_SUPPORT' -I../deps/v8 -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++0x -MMD -MF /home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1204-clang341-64/out/Release/.deps//home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1204-clang341-64/out/Release/obj.target/v8_libbase/deps/v8/src/base/logging.o.d.raw -c -o /home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1204-clang341-64/out/Release/obj.target/v8_libbase/deps/v8/src/base/logging.o ../deps/v8/src/base/logging.cc clang: warning: argument unused during compilation: '-I ../deps/v8' In file included from ../deps/v8/src/base/functional.cc:11: In file included from ../deps/v8/src/base/functional.h:11: /usr/bin/../lib/gcc/x86_64-linux-gnu/4.9/../../../../include/c++/4.9/cstddef:51:11: error: no member named 'max_align_t' in the global namespace using ::max_align_t; ~~^

Additionally, I see a lot of these warnings in the output:

clang: warning: argument unused during compilation: '-I ../deps/v8'

Not sure if it's related to the error or not...

MylesBorins · 2017-03-29T00:18:15Z

@mscdex I'm not 100% but I think that build is with a non standard version of clang and the failure is currently expected

/cc @bnoordhuis

PR-URL: #12104

Notable changes: * buffer: - do not segfault on out-of-range index (Timothy Gu) #11927 * crypto: - Fix memory leak if certificate is revoked (Tom Atkinson) #12089 * deps: * upgrade npm to 4.2.0 (Kat Marchán) #11389 * fix async await desugaring in V8 (Michaël Zasso) #12004 * readline: - add option to stop duplicates in history (Danny Nemer) #2982 * src: - add native URL class (James M Snell) #11801 PR-URL: #12104

Notable changes: * buffer: - do not segfault on out-of-range index (Timothy Gu) nodejs/node#11927 * crypto: - Fix memory leak if certificate is revoked (Tom Atkinson) nodejs/node#12089 * deps: * upgrade npm to 4.2.0 (Kat Marchán) nodejs/node#11389 * fix async await desugaring in V8 (Michaël Zasso) nodejs/node#12004 * readline: - add option to stop duplicates in history (Danny Nemer) nodejs/node#2982 * src: - add native URL class (James M Snell) nodejs/node#11801 PR-URL: nodejs/node#12104 Signed-off-by: Ilkka Myller <[email protected]>

targosand others added 30 commits March 27, 2017 10:14

test: synchronize WPT url setters tests data
169f187
Synchronize url-setter-test to upstream. Refs: web-platform-tests/wpt#5112 PR-URL: #11887 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

doc: fix gitter badge in README
04fa28e
GitHub now renders Markdown in CommonMark where spaces in a link destination are invalid and need to be escaped. PR-URL: #11944 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

benchmark: fix fs\bench-realpathSync.js
d62ddbe
Make it call-site-cwd-independent. PR-URL: #11904 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

test: fix flaky test-tls-socket-close
9ba551f
Replace timer/timeout race with event-based ordering, eliminating test flakiness. PR-URL: #11921Fixes: #11912 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]>

src, buffer: do not segfault on out-of-range index
59f71f5
Also add test cases for partial writes and invalid indices. PR-URL: #11927Fixes: #8724 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

benchmark: harmonize progress bar + stderr output
2f4ad6f
Add a space for minimal readability. PR-URL: #11925 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>

build: don't create directory for NDK toolchain
3e4ecca
Let make-standalone-toolchain.sh create directory. PR-URL: #11916 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>

doc: require uses fs root for '/' prefix
486bd1b
PR-URL: #11897Fixes: #7151 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

errors: remove needless lazyAssert
0f2642e
PR-URL: #11891 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

deps: upgrade npm to 4.2.0
2767e2d
PR-URL: #11389 Reviewed-By: Jeremiah Senkpiel <[email protected]>

test: do not use more command on Windows
bb2de4a
PR-URL: #11953Fixes: #11469 Reviewed-By: João Reis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>

url: show input in parse error message
f675518
PR-URL: #11934 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>

fhinkeland others added 4 commits March 28, 2017 19:26

MylesBorins added the v7.x label Mar 28, 2017

nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. v7.x labels Mar 28, 2017

MylesBorins force-pushed the v7.8.0-proposal branch from aef5dfb to de29b02Compare March 28, 2017 23:48

MylesBorins force-pushed the v7.8.0-proposal branch from de29b02 to f04524eCompare March 28, 2017 23:55

vsemozhetbyt mentioned this pull request Mar 29, 2017
A bookmarklet to check commit messages in PRs #12107
Closed

MylesBorins merged commit f04524e into v7.xMar 29, 2017

MylesBorins added a commit that referenced this pull request Mar 29, 2017
Working on v7.8.1
517f13b
PR-URL: #12104

addaleax deleted the v7.8.0-proposal branch March 29, 2017 03:01

MylesBorins mentioned this pull request Mar 29, 2017
blog: release post for v7.8.0 nodejs/nodejs.org#1184
Merged

mscdex mentioned this pull request Apr 11, 2017
v7.9.0 Release Proposal #12319
Merged
2 tasks

aqrln mentioned this pull request Apr 11, 2017
(v7.x-backport) build: enable cctest to use generated objects #12321
Closed
2 tasks

gibfahn mentioned this pull request Apr 24, 2017
ubuntu1204-clang341 has been disabled in CI nodejs/build#685
Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

V7.8.0 proposal#12104

V7.8.0 proposal #12104

Uh oh!

MylesBorins commented Mar 28, 2017•
edited
Loading

Uh oh!

MylesBorins commented Mar 28, 2017•
edited
Loading

Uh oh!

MylesBorins commented Mar 28, 2017

Uh oh!

addaleax commented Mar 28, 2017

Uh oh!

italoacasas commented Mar 28, 2017•
edited
Loading

Uh oh!

mscdex commented Mar 29, 2017

Uh oh!

MylesBorins commented Mar 29, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

V7.8.0 proposal#12104

V7.8.0 proposal #12104

Uh oh!

Conversation

MylesBorins commented Mar 28, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2017-03-28, Version 7.8.0 (Current), @MylesBorins

Notable Changes

Commits

Uh oh!

MylesBorins commented Mar 28, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MylesBorins commented Mar 28, 2017

Uh oh!

addaleax commented Mar 28, 2017

Uh oh!

italoacasas commented Mar 28, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mscdex commented Mar 29, 2017

Uh oh!

MylesBorins commented Mar 29, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

MylesBorins commented Mar 28, 2017•
edited
Loading

MylesBorins commented Mar 28, 2017•
edited
Loading

italoacasas commented Mar 28, 2017•
edited
Loading