doc: update collaborator email address#11996
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added libuv 
Per email conversation with Shigeki Ohtsu, updating email address in docs. The current listed email address does not work anymore.
Trott removed the libuv 
addaleax approved these changes Mar 22, 2017
Member
addaleax left a comment
addaleax left a comment There was a problem hiding this comment.
https://github.com/nodejs/email too, I assume?
jasnell approved these changes Mar 22, 2017
MemberAuthor
Trott commented Mar 23, 2017
@addaleax wrote:
Yes: nodejs/email#37 |
shigeki approved these changes Mar 23, 2017
Contributor
shigeki left a comment
shigeki left a comment There was a problem hiding this comment.
Thanks for taking care of this. I missed it.
Member
jasnell commented Mar 23, 2017
This should not need the 48 hours to land |
Contributor
shigeki commented Mar 23, 2017
I'll land this. After rubber stamping of CI result in https://ci.nodejs.org/job/node-test-commit/8628/. |
shigeki pushed a commit that referenced this pull request Mar 23, 2017
Per email conversation with Shigeki Ohtsu, updating email address in docs. The current listed email address does not work anymore. PR-URL: #11996 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
Contributor
shigeki commented Mar 23, 2017
All is green. Landed in 8a639bb. Thanks. |
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
Per email conversation with Shigeki Ohtsu, updating email address in docs. The current listed email address does not work anymore. PR-URL: #11996 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
Per email conversation with Shigeki Ohtsu, updating email address in docs. The current listed email address does not work anymore. PR-URL: #11996 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
Per email conversation with Shigeki Ohtsu, updating email address in docs. The current listed email address does not work anymore. PR-URL: #11996 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
Per email conversation with Shigeki Ohtsu, updating email address in docs. The current listed email address does not work anymore. PR-URL: nodejs/node#11996 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per email conversation with Shigeki Ohtsu, updating email address in
docs. The current listed email address does not work anymore.
Checklist
Affected core subsystem(s)
doc