src, buffer: do not segfault on out-of-range index#11927
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Also add test cases for partial writes and invalid indices. Fixes: nodejs#8724
TimothyGu added buffer 
nodejs-github-bot added buffer MemberAuthor
TimothyGu commented Mar 19, 2017
No significant performance changes: |
MemberAuthor
TimothyGu commented Mar 19, 2017
| size_t def, | ||
| size_t* ret){ | ||
| size_t* ret, | ||
| size_t needed = 0){ |
Member
There was a problem hiding this comment.
Yeah, I mean, inside of ParseArrayIndex? I feel like I am missing the point of passing this argument…
MemberAuthor
There was a problem hiding this comment.
Wait... oops, git commit -p fail. Updated patch incoming.
jasnell approved these changes Mar 20, 2017
MemberAuthor
TimothyGu commented Mar 22, 2017
@addaleax, @bnoordhuis, PTAL. |
addaleax approved these changes Mar 22, 2017
Member
addaleax left a comment
addaleax left a comment There was a problem hiding this comment.
src/ changes LGTM.
The test file is a bit hard to grok but the changes are additive, so … ¯\_(ツ)_/¯
jasnell pushed a commit that referenced this pull request Mar 22, 2017
Also add test cases for partial writes and invalid indices. PR-URL: #11927Fixes: #8724 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Member
jasnell commented Mar 22, 2017
Landed in 4fb9b12 |
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
Also add test cases for partial writes and invalid indices. PR-URL: #11927Fixes: #8724 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
MylesBorins added a commit that referenced this pull request Mar 28, 2017
Notable changes: * buffer: - do not segfault on out-of-range index (Timothy Gu) #11927 * crypto: - Fix memory leak if certificate is revoked (Tom Atkinson) #12089 * deps: * upgrade npm to 4.2.0 (Kat Marchán) #11389 * fix async await desugaring in V8 (Michaël Zasso) #12004 * readline: - add option to stop duplicates in history (Danny Nemer) #2982 * src: - add native URL class (James M Snell) #11801 PR-URL: #12104
MylesBorins added a commit that referenced this pull request Mar 29, 2017
Notable changes: * buffer: - do not segfault on out-of-range index (Timothy Gu) #11927 * crypto: - Fix memory leak if certificate is revoked (Tom Atkinson) #12089 * deps: * upgrade npm to 4.2.0 (Kat Marchán) #11389 * fix async await desugaring in V8 (Michaël Zasso) #12004 * readline: - add option to stop duplicates in history (Danny Nemer) #2982 * src: - add native URL class (James M Snell) #11801 PR-URL: #12104
Contributor
MylesBorins commented Apr 18, 2017
Landed on v6.x-staging. Not landing cleanly on v4.x due to differences in releases. please feel free to change label and backport |
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
Also add test cases for partial writes and invalid indices. PR-URL: #11927Fixes: #8724 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
Also add test cases for partial writes and invalid indices. PR-URL: #11927Fixes: #8724 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
imyller added a commit to imyller/meta-nodejs that referenced this pull request Apr 20, 2017
Notable changes: * buffer: - do not segfault on out-of-range index (Timothy Gu) nodejs/node#11927 * crypto: - Fix memory leak if certificate is revoked (Tom Atkinson) nodejs/node#12089 * deps: * upgrade npm to 4.2.0 (Kat Marchán) nodejs/node#11389 * fix async await desugaring in V8 (Michaël Zasso) nodejs/node#12004 * readline: - add option to stop duplicates in history (Danny Nemer) nodejs/node#2982 * src: - add native URL class (James M Snell) nodejs/node#11801 PR-URL: nodejs/node#12104 Signed-off-by: Ilkka Myller <[email protected]>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
Also add test cases for partial writes and invalid indices. PR-URL: nodejs/node#11927Fixes: nodejs/node#8724 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add test cases for partial writes and invalid indices.
Fixes: #8724
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src, buffer