src: use persistent strings from node::Environment#11945
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Replace a few calls to FIXED_ONE_BYTE_STRING() with their persistent counterparts from `node::Environment`. None of the calls are in hot code paths but why create a new string when one already exists?
nodejs-github-bot added c++ 
addaleax approved these changes Mar 20, 2017
cjihrig approved these changes Mar 20, 2017
jasnell approved these changes Mar 20, 2017
Fishrock123 approved these changes Mar 20, 2017
Contributor
mscdex commented Mar 20, 2017
LGTM if CI is ok: https://ci.nodejs.org/job/node-test-pull-request/6942/ |
jasnell pushed a commit that referenced this pull request Mar 22, 2017
Replace a few calls to FIXED_ONE_BYTE_STRING() with their persistent counterparts from `node::Environment`. None of the calls are in hot code paths but why create a new string when one already exists? PR-URL: #11945 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Brian White <[email protected]>
Member
jasnell commented Mar 22, 2017
Landed in f35e80d |
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
Replace a few calls to FIXED_ONE_BYTE_STRING() with their persistent counterparts from `node::Environment`. None of the calls are in hot code paths but why create a new string when one already exists? PR-URL: #11945 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Brian White <[email protected]>
Merged
Contributor
MylesBorins commented Apr 18, 2017
should we backport this to lts? |
MemberAuthor
bnoordhuis commented Apr 18, 2017
It's not strictly necessary but might save a few future merge conflicts. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace a few calls to FIXED_ONE_BYTE_STRING() with their persistent
counterparts from
node::Environment. None of the calls are in hotcode paths but why create a new string when one already exists?