url: name anonymous functions in url#9225
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the url 
jasnell approved these changes Oct 21, 2016
targos approved these changes Oct 21, 2016
lpinca approved these changes Oct 24, 2016
Member
jasnell commented Oct 24, 2016
2 tasks
fhinkel approved these changes Mar 26, 2017
Member
fhinkel commented Mar 26, 2017
Thanks. Sorry for taking so long, this PR must have gotten overlooked. Landed in c1dee6a |
fhinkel pushed a commit that referenced this pull request Mar 26, 2017
Name anonymous functions in url.js. PR-URL: #9225 Ref: #8913 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Member
I think this didn't land before because functions names were already inferred from |
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
Name anonymous functions in url.js. PR-URL: #9225 Ref: #8913 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Merged
MylesBorins added the baking-for-lts MylesBorins added dont-land-on-v6.x and removed baking-for-lts Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
url
Description of change
url: name anonymous functions in url
name anonymous functions in url module
the changes are related to commits ef030da and accf410
which are naming anonymous functions to standardize the code
and help debugging, also with Ref: #8913