lib: remove an unnecessary coverage check#12023
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fishrock123force-pushed the coverage-remove-unnecessary-check branch from 7a1d341 to 4b7132cCompare
cjihrig approved these changes Mar 24, 2017
Fishrock123 added the lib / src 
jasnell approved these changes Mar 24, 2017
addaleax approved these changes Mar 24, 2017
fhinkel approved these changes Mar 26, 2017
Member
fhinkel commented Mar 26, 2017
Landed in 59d2561 |
fhinkel pushed a commit that referenced this pull request Mar 26, 2017
PR-URL: #12023Fixes: #11445 Refs: f65a48f Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
PR-URL: #12023Fixes: #11445 Refs: f65a48f Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
coverage
Fixes: #11445
Refs: f65a48f
Based on @addaleax's comment here.
Before (coverage.nodejs.org,
master)After
And the specific
process._exitinglines that f65a48f was supposed to hit are indeed hit with this change:cc @addaleax, @mhdawson@CurryKitten