deps: upgrade libuv to 1.12.0#13306

cjihrig · 2017-05-30T17:22:01Z

If anyone knows of any Node.js issues that are resolved by this release, please link them here so they can be added to the commit metadata, and closed on landing.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

deps

BridgeAR · 2017-05-30T17:36:08Z

Solves #12853. As far as I see it, it's the only issue closed by the upgrade.

mscdex · 2017-05-30T20:17:35Z

deps/uv/.github/ISSUE_TEMPLATE.md

Surely this file can be ignored?

Fishrock123 · 2017-05-30T20:43:50Z

I believe one of the oldest still-open issues, #854, is fixed by this?

Assuming unix: remove FSEventStreamFlushSync() call is in this release.

bnoordhuis

LGTM

Anyone have opinions on whether to gitignore the uvbook files in docs/code and docs/src/guide? It adds another ~100 kB to the tarball (240 kB uncompressed) and I don't expect many people will look at it.

Important change: this version of libuv raises the minimum supported version from linux 2.6.18 + glibc 2.5 to linux 2.6.32 + glibc 2.12.

The support code for older systems is still there but going forward we won't bend over backwards to keep it in working shape.

jasnell · 2017-05-30T23:02:11Z

+1 to ignoring the uvbook files

jasnell

Rubber stamp LGTM but I'd like to see a CITGM run before this lands.

mhdawson

Rubber stamp approval from me as well provided CI passes.

cjihrig · 2017-06-01T15:55:29Z

@bnoordhuis should the uvbook be explicitly added to .gitignore, or just not checked in?

bnoordhuis · 2017-06-01T16:00:21Z

@cjihrig I'd add it to the .gitignore, that prevents accidental check-ins in the future.

cjihrig · 2017-06-01T17:14:30Z

Removed the uvbook and .github folders. PTAL

richardlau · 2017-06-01T18:03:41Z

Important change: this version of libuv raises the minimum supported version from linux 2.6.18 + glibc 2.5 to linux 2.6.32 + glibc 2.12.

We should also raise Node.js' minimum supported levels in BUILDING.md to match.

cjihrig · 2017-06-05T01:44:15Z

Added a commit to update BUILDING.md.

bnoordhuis · 2017-06-05T10:28:36Z

Still LGTM. The raised baseline might become non-academic in the future, see libuv/libuv#1372.

Fishrock123 · 2017-06-05T13:00:18Z

@cjihrig could you please move the .gitignore change into it's own commit?

cjihrig · 2017-06-05T14:27:29Z

Moved to separate commit. CI: https://ci.nodejs.org/job/node-test-pull-request/8482/

cjihrig · 2017-06-05T19:39:08Z

CI seemed good. Ran CITGM (https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/854/). Can someone help interpreting the output?

gibfahn · 2017-06-05T20:22:02Z

cc/ @nodejs/citgm

Fixes: nodejs#12853Fixes: nodejs#854 PR-URL: nodejs#13306 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

The libuv 1.12.0 update bumped the minimum supported version of linux + glibc. This commit updates BUILDING.md to reflect the new values. PR-URL: nodejs#13306 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

* **Async Hooks** * When one `Promise` leads to the creation of a new `Promise`, the parent `Promise` will be identified as the trigger [[`135f4e6643`](nodejs@135f4e6643)] [nodejs#13367](nodejs#13367). * **Dependencies** * libuv has been updated to 1.12.0 [[`968596ec77`](nodejs@968596ec77)] [nodejs#13306](nodejs#13306). * npm has been updated to 5.0.3 [[`ffa7debd7a`](nodejs@ffa7debd7a)] [nodejs#13487](nodejs#13487). * **File system** * The `fs.exists()` function now works correctly with `util.promisify()` [[`6e0eccd7a1`](nodejs@6e0eccd7a1)] [nodejs#13316](nodejs#13316). * fs.Stats times are now also available as numbers [[`c756efb25a`](nodejs@c756efb25a)] [nodejs#13173](nodejs#13173). * **Inspector** * It is now possible to bind to a random port using `--inspect=0` [[`cc6ec2fb27`](nodejs@cc6ec2fb27)] [nodejs#5025](nodejs#5025). * **Zlib** * A regression in the Zlib module that made it impossible to properly subclasses `zlib.Deflate` and other Zlib classes has been fixed. [[`6aeb555cc4`](nodejs@6aeb555cc4)] [nodejs#13374](nodejs#13374).

* **Async Hooks** * When one `Promise` leads to the creation of a new `Promise`, the parent `Promise` will be identified as the trigger [[`135f4e6643`](135f4e6643)] [#13367](#13367). * **Dependencies** * libuv has been updated to 1.12.0 [[`968596ec77`](968596ec77)] [#13306](#13306). * npm has been updated to 5.0.3 [[`ffa7debd7a`](ffa7debd7a)] [#13487](#13487). * **File system** * The `fs.exists()` function now works correctly with `util.promisify()` [[`6e0eccd7a1`](6e0eccd7a1)] [#13316](#13316). * fs.Stats times are now also available as numbers [[`c756efb25a`](c756efb25a)] [#13173](#13173). * **Inspector** * It is now possible to bind to a random port using `--inspect=0` [[`cc6ec2fb27`](cc6ec2fb27)] [#5025](#5025). * **Zlib** * A regression in the Zlib module that made it impossible to properly subclasses `zlib.Deflate` and other Zlib classes has been fixed. [[`6aeb555cc4`](6aeb555cc4)] [#13374](#13374).

MylesBorins · 2017-07-17T17:53:32Z

Can we get this backported to v6.x for a future semver minor

MylesBorins · 2017-09-19T21:26:20Z

@cjihrig @bnoordhuis do you see any issues with backporting this to v6.x? The minimal version of kernel + libc are slightly worrysome, but your comments appear to imply that it isn't a big deal.

gibfahn · 2017-09-19T21:29:04Z

Could we backport this version without backporting the supported versions update? @bnoordhuis you mentioned that it was academic for this release, and this is likely to be the last libuv update for 6.x.

bnoordhuis · 2017-09-19T22:14:40Z

None of the support code for old kernels was removed so yes, this is safe to back-port.

Fixes: #12853Fixes: #854 PR-URL: #13306 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

PR-URL: #13306 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Fixes: #12853Fixes: #854 PR-URL: #13306 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

PR-URL: #13306 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Notable Changes: * assert: - assert.fail() can now take one or two arguments (Rich Trott) #12293 * crypto: - add sign/verify support for RSASSA-PSS (Tobias Nießen) #11705 * deps: - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) #16691 - upgrade libuv to 1.15.0 (cjihrig) #15745 - upgrade libuv to 1.14.1 (cjihrig) #14866 - upgrade libuv to 1.13.1 (cjihrig) #14117 - upgrade libuv to 1.12.0 (cjihrig) #13306 * fs: - Add support for fs.write/fs.writeSync(fd, buffer, cb) and fs.write/fs.writeSync(fd, buffer, offset, cb) as documented (Andreas Lind) #7856 * inspector: - enable --inspect-brk (Refael Ackermann) #12615 * process: - add --redirect-warnings command line argument (James M Snell) #10116 * src: - allow CLI args in env with NODE_OPTIONS (Sam Roberts) #12028) - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts) #13932 - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts) #13172 - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts) #12677 * test: - remove common.fail() (Rich Trott) #12293 PR-URL: #16263

uttampawar · 2018-06-14T19:35:43Z

Is there a timeline when this can land? Thanks.

cjihrig · 2018-06-14T19:37:58Z

Land where? Node 6 is the oldest supported release line and it has a newer version of libuv than this.

uttampawar · 2018-06-15T16:58:13Z

@cjihrig I thought that content of libuv/libuv#1372 is getting pulled in as part of this PR which I realized is not the case. I apologize for the confusion, it was misunderstanding on my part.

nodejs-github-bot added build Issues and PRs related to build files or the CI. libuv Issues and PRs related to the libuv dependency or the uv binding. labels May 30, 2017

cjihrig requested review from saghul and removed request for saghul May 30, 2017 17:22

mscdex reviewed May 30, 2017
View reviewed changes

deps/uv/.github/ISSUE_TEMPLATE.md Outdated
Copy link
Contributor
mscdexMay 30, 2017
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surely this file can be ignored?
jasnell reacted with thumbs up emoji

santigimeno approved these changes May 30, 2017
View reviewed changes

bnoordhuis approved these changes May 30, 2017
View reviewed changes

jasnell approved these changes May 30, 2017
View reviewed changes

mhdawson approved these changes May 31, 2017
View reviewed changes

cjihrig force-pushed the uv branch 2 times, most recently from cf680b8 to 59b0847Compare June 1, 2017 17:03

cjihrig force-pushed the uv branch 2 times, most recently from 871ed57 to 9b40352Compare June 5, 2017 01:43

cjihrig force-pushed the uv branch from 9b40352 to d6dd186Compare June 5, 2017 14:26

bricss mentioned this pull request Jun 5, 2017
8.1.0 Tracking Issue #13475
Closed

cjihrig added 2 commits June 7, 2017 09:30

deps: upgrade libuv to 1.12.0
edd5419
Fixes: nodejs#12853Fixes: nodejs#854 PR-URL: nodejs#13306 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

gibfahn mentioned this pull request Jun 15, 2017
Auditing for 6.11.1 nodejs/Release#230
Closed
3 tasks

MylesBorins added backport-requested-v6.x semver-minor PRs that contain new features and should be released in the next minor version. labels Jul 17, 2017

bnoordhuis mentioned this pull request Aug 16, 2017
deps: upgrade libuv to 1.13.1 #14117
Merged
2 tasks

MylesBorins added land-on-v6.x and removed backport-requested-v6.x labels Oct 16, 2017

cjihrig mentioned this pull request Oct 16, 2017
deps: upgrade libuv to 1.15.0 #15745
Merged
2 tasks

MylesBorins mentioned this pull request Oct 17, 2017
v6.12.0 proposal #16263
Merged

MylesBorins mentioned this pull request Nov 3, 2017
v4.8.6 proposal #16500
Merged

uttampawar mentioned this pull request Jun 14, 2018
Making socket api access transparent libuv/libuv#1880
Closed

Uh oh!

deps: upgrade libuv to 1.12.0#13306

deps: upgrade libuv to 1.12.0 #13306

Uh oh!

Conversation

cjihrig commented May 30, 2017

Checklist

Affected core subsystem(s)

Uh oh!

BridgeAR commented May 30, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mscdexMay 30, 2017

Choose a reason for hiding this comment

Uh oh!

Fishrock123 commented May 30, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell commented May 30, 2017

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

cjihrig commented Jun 1, 2017

Uh oh!

bnoordhuis commented Jun 1, 2017

Uh oh!

cjihrig commented Jun 1, 2017

Uh oh!

richardlau commented Jun 1, 2017

Uh oh!

cjihrig commented Jun 5, 2017

Uh oh!

bnoordhuis commented Jun 5, 2017

Uh oh!

Fishrock123 commented Jun 5, 2017

Uh oh!

cjihrig commented Jun 5, 2017

Uh oh!

cjihrig commented Jun 5, 2017

Uh oh!

gibfahn commented Jun 5, 2017

Uh oh!

MylesBorins commented Jul 17, 2017

Uh oh!

MylesBorins commented Sep 19, 2017

Uh oh!

gibfahn commented Sep 19, 2017

Uh oh!

bnoordhuis commented Sep 19, 2017

Uh oh!

uttampawar commented Jun 14, 2018

Uh oh!

cjihrig commented Jun 14, 2018

Uh oh!

uttampawar commented Jun 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

BridgeAR commented May 30, 2017•
edited
Loading

Fishrock123 commented May 30, 2017•
edited
Loading