deps: upgrade libuv to 1.15.0#15745
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added build 
Contributor
mscdex commented Oct 3, 2017
Member
jasnell commented Oct 3, 2017
Can you provide a summary of the key changes in the PR text above? |
ContributorAuthor
cjihrig commented Oct 3, 2017
jasnell approved these changes Oct 3, 2017
ContributorAuthor
cjihrig commented Oct 3, 2017
I've added some notable changes and linked to some issues for the PR metadata. To be honest, there isn't a ton that Node should care too much about, although @evanlucas might be interested to see that @bnoordhuis picked up libuv/libuv#641. |
refack approved these changes Oct 3, 2017
Contributor
evanlucas commented Oct 3, 2017
Thanks @bnoordhuis! I couldn't quite get it right :]. |
Merged
Member
santigimeno commented Oct 5, 2017
It fixes: #15770 too |
Refs: nodejs#15380 Refs: nodejs#15683Fixes: nodejs#15394Fixes: nodejs#15770 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 5, 2017
PR-URL: nodejs#15745 Refs: nodejs#15380 Refs: nodejs#15683Fixes: nodejs#15394Fixes: nodejs#15770 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
Trott commented Oct 5, 2017
Force pushed fca6c58 to add the missing metadata. |
MylesBorins pushed a commit that referenced this pull request Oct 7, 2017
PR-URL: #15745 Refs: #15380 Refs: #15683Fixes: #15394Fixes: #15770 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
4 tasks
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
PR-URL: #15745 Refs: #15380 Refs: #15683Fixes: #15394Fixes: #15770 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Oct 11, 2017
Notable Changes: * deps: * update npm to 5.4.2 #15600 * upgrade libuv to 1.15.0 #15745 * update V8 to 6.1.534.42 #15393 * dgram: * support for setting dgram socket buffer size #13623 * fs: * add support O_DSYNC file open constant #15451 * util: * deprecate obj.inspect for custom inspection #15631 * tools, build: * there is a fancy new macOS installer #15179 * Added new collaborator * bmeurer - Benedikt Meurer - https://github.com/bmeurer * kfarnung - Kyle Farnung - https://github.com/kfarnung PR-URL: #15762
MylesBorins added a commit that referenced this pull request Oct 11, 2017
Notable Changes: * deps: * update npm to 5.4.2 #15600 * upgrade libuv to 1.15.0 #15745 * update V8 to 6.1.534.42 #15393 * dgram: * support for setting dgram socket buffer size #13623 * fs: * add support O_DSYNC file open constant #15451 * util: * deprecate obj.inspect for custom inspection #15631 * tools, build: * there is a fancy new macOS installer #15179 * Added new collaborator * bmeurer - Benedikt Meurer - https://github.com/bmeurer * kfarnung - Kyle Farnung - https://github.com/kfarnung PR-URL: #15762
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
PR-URL: nodejs/node#15745 Refs: nodejs/node#15380 Refs: nodejs/node#15683Fixes: nodejs/node#15394Fixes: nodejs/node#15770 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
Notable Changes: * deps: * update npm to 5.4.2 nodejs/node#15600 * upgrade libuv to 1.15.0 nodejs/node#15745 * update V8 to 6.1.534.42 nodejs/node#15393 * dgram: * support for setting dgram socket buffer size nodejs/node#13623 * fs: * add support O_DSYNC file open constant nodejs/node#15451 * util: * deprecate obj.inspect for custom inspection nodejs/node#15631 * tools, build: * there is a fancy new macOS installer nodejs/node#15179 * Added new collaborator * bmeurer - Benedikt Meurer - https://github.com/bmeurer * kfarnung - Kyle Farnung - https://github.com/kfarnung PR-URL: nodejs/node#15762
Contributor
MylesBorins commented Oct 16, 2017
Do we want to include this in the upcoming 6.x LTS minor? It may be the last minor for the 6.x release line. That being said I don't want to rush ti if this could potentially complicate things /cc @nodejs/tsc @nodejs/lts |
ContributorAuthor
cjihrig commented Oct 16, 2017
I think this would be good to get into Node 6 due to the mentioned notable changes. I understand if people don't want to rush it though. |
Contributor
mscdex commented Oct 16, 2017
Are we sure that recent versions of libuv still work on all of the platforms supported by node v6.x? |
ContributorAuthor
cjihrig commented Oct 16, 2017
As of 1.12.0, it was safe to backport. I just looked through the Changelog since then, and it still appears to be the case. Perhaps @bnoordhuis can confirm though. |
Member
bnoordhuis commented Oct 17, 2017
Yes, no legacy code has been removed so far. |
MylesBorins added land-on-v6.x semver-minor MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
PR-URL: #15745 Refs: #15380 Refs: #15683Fixes: #15394Fixes: #15770 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
PR-URL: #15745 Refs: #15380 Refs: #15683Fixes: #15394Fixes: #15770 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins added a commit that referenced this pull request Nov 6, 2017
Notable Changes: * assert: - assert.fail() can now take one or two arguments (Rich Trott) #12293 * crypto: - add sign/verify support for RSASSA-PSS (Tobias Nießen) #11705 * deps: - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) #16691 - upgrade libuv to 1.15.0 (cjihrig) #15745 - upgrade libuv to 1.14.1 (cjihrig) #14866 - upgrade libuv to 1.13.1 (cjihrig) #14117 - upgrade libuv to 1.12.0 (cjihrig) #13306 * fs: - Add support for fs.write/fs.writeSync(fd, buffer, cb) and fs.write/fs.writeSync(fd, buffer, offset, cb) as documented (Andreas Lind) #7856 * inspector: - enable --inspect-brk (Refael Ackermann) #12615 * process: - add --redirect-warnings command line argument (James M Snell) #10116 * src: - allow CLI args in env with NODE_OPTIONS (Sam Roberts) #12028) - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts) #13932 - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts) #13172 - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts) #12677 * test: - remove common.fail() (Rich Trott) #12293 PR-URL: #16263
MylesBorins added a commit that referenced this pull request Nov 7, 2017
Notable Changes: * assert: - assert.fail() can now take one or two arguments (Rich Trott) #12293 * crypto: - add sign/verify support for RSASSA-PSS (Tobias Nießen) #11705 * deps: - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) #16691 - upgrade libuv to 1.15.0 (cjihrig) #15745 - upgrade libuv to 1.14.1 (cjihrig) #14866 - upgrade libuv to 1.13.1 (cjihrig) #14117 - upgrade libuv to 1.12.0 (cjihrig) #13306 * fs: - Add support for fs.write/fs.writeSync(fd, buffer, cb) and fs.write/fs.writeSync(fd, buffer, offset, cb) as documented (Andreas Lind) #7856 * inspector: - enable --inspect-brk (Refael Ackermann) #12615 * process: - add --redirect-warnings command line argument (James M Snell) #10116 * src: - allow CLI args in env with NODE_OPTIONS (Sam Roberts) #12028) - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts) #13932 - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts) #13172 - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts) #12677 * test: - remove common.fail() (Rich Trott) #12293 PR-URL: #16263
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable Changes
uv_fs_copyfile(), which is used byfs.copyFile().UV_PROCESS_WINDOWS_HIDEto hide console windows.Refs: #15380
Refs: #15683
Fixes: #15394
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
deps