refactor away test/inspector#16197
refactor away test/inspector #16197
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added the build 
mscdex added inspector 
Trott commented Oct 14, 2017
Trott commented Oct 14, 2017
@nodejs/v8-inspector |
Trott commented Oct 14, 2017
@maclover7 A third bullet point might be "evaluate if any of these tests can/should be moved to parallel". |
There was a problem hiding this comment.
You could use common.fixtures.path('inspector-global-function.js') here.
Makefile Outdated
There was a problem hiding this comment.
Can you also remove it from vcbuild.bat? (Two mentions.)
refack left a comment
refack left a comment There was a problem hiding this comment.
Need the FLAKY flags moved as well
test/inspector/inspector.status Outdated
There was a problem hiding this comment.
Shouldn't these be moved to test/parallel/parallel.status
There was a problem hiding this comment.
Good catch -- thank you!
joyeecheung commented Oct 16, 2017
jasnell commented Oct 16, 2017
Several related failures in CI, including linting issues. |
maclover7 commented Oct 16, 2017
@jasnell fixed linter issue and moved one of the tests to sequential, would you be willing to run CI again? |
* remove inspector directory artifacts PR-URL: nodejs#16197 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
refack commented Oct 17, 2017
Landed in 978629c 10x! 🎉 |
* remove inspector directory artifacts PR-URL: #16197 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
* remove inspector directory artifacts PR-URL: nodejs/node#16197 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
refack commented Oct 18, 2017
Cross-ref: #16281 |
10 participants
Refs: #13622, cc @Trott@refack
Tried to handle as much as I could in this PR, but there here are some things I'd like to handle in separate PRs:
inspector-helper.jsto a proper "common" module (write basic docs, etc.)test/inspectorare gonetest/parallelChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test