test: fix inspector tests#16281
Closed
test: fix inspector tests #16281
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott added flaky-test 
The inspector tests should not be in the parallel directory as they likely all (or certainly almost all) use static ports, so port collisions will happen. This moves them all to sequential. We can move them back on a case-by-case basis. They were run sequentially when they were in the inspector directory which they were only moved from very recently.
Trottforce-pushed the fix-inspector-tirefire branch from ec5bff3 to 8a217d7Compare
MemberAuthor
Trott commented Oct 18, 2017
MemberAuthor
Trott commented Oct 18, 2017
@nodejs/collaborators If you happen to be available right about now, it would be great to get this reviewed and fast-tracked. |
danbev approved these changes Oct 18, 2017
hiroppy approved these changes Oct 18, 2017
joyeecheung approved these changes Oct 18, 2017
bengl approved these changes Oct 18, 2017
MemberAuthor
Trott commented Oct 18, 2017
Single failure in Linux is unrelated. Failures on Raspberry Pi device is a build problem on a single device (that has since been taken offline). Everything else passed. |
MemberAuthor
Trott commented Oct 18, 2017
Given the high impact on CI and the ease with which any of this can be reverted if necessary (it's mostly moving files from one directory to another), I'm going to land... |
Trott added a commit to Trott/io.js that referenced this pull request Oct 18, 2017
The inspector tests should not be in the parallel directory as they likely all (or certainly almost all) use static ports, so port collisions will happen. This moves them all to sequential. We can move them back on a case-by-case basis. They were run sequentially when they were in the inspector directory which they were only moved from very recently. PR-URL: nodejs#16281 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Bryan English <[email protected]>
MemberAuthor
Trott commented Oct 18, 2017
Landed in 9be3d99 |
targos pushed a commit that referenced this pull request Oct 18, 2017
The inspector tests should not be in the parallel directory as they likely all (or certainly almost all) use static ports, so port collisions will happen. This moves them all to sequential. We can move them back on a case-by-case basis. They were run sequentially when they were in the inspector directory which they were only moved from very recently. PR-URL: #16281 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Bryan English <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 18, 2017
The inspector tests should not be in the parallel directory as they likely all (or certainly almost all) use static ports, so port collisions will happen. This moves them all to sequential. We can move them back on a case-by-case basis. They were run sequentially when they were in the inspector directory which they were only moved from very recently. PR-URL: nodejs/node#16281 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Bryan English <[email protected]>
3 tasks
Contributor
maclover7 commented Oct 18, 2017
sorry this was my bad 😞 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inspector tests should not be in the parallel directory as they
likely all (or certainly almost all) use static ports, so port
collisions ("address already in use") will happen.
This moves them all to sequential. We can move them back on a
case-by-case basis. They were run sequentially when they were in the
inspector directory which they were only moved from very recently.
Example problem:
https://ci.nodejs.org/job/node-test-commit-linuxone/9482/nodes=rhel72-s390x/console
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test inspector