test: remove --harmony-sharedarraybuffer usage#16343
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This flag has been enabled by default since v8 7662e0634c3a057fa5d746912ee5af76e285c274.
Fishrock123 approved these changes Oct 20, 2017
addaleax approved these changes Oct 20, 2017
jasnell approved these changes Oct 20, 2017
mscdex added buffer 
cjihrig approved these changes Oct 20, 2017
apapirovski approved these changes Oct 20, 2017
targos approved these changes Oct 21, 2017
lpinca approved these changes Oct 21, 2017
joyeecheung approved these changes Oct 21, 2017
Member
joyeecheung left a comment
joyeecheung left a comment There was a problem hiding this comment.
CI failures are unrelated. I think we can skip the 48-hour wait on this
Member
addaleax commented Oct 22, 2017
Landed in 438e7fd, thanks! |
addaleax pushed a commit that referenced this pull request Oct 22, 2017
This flag has been enabled by default since v8 7662e0634c3a057fa5d746912ee5af76e285c274. PR-URL: #16343 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
Contributor
MylesBorins commented Oct 23, 2017
This shouldn't land on 8.x until 6.2 is backported. @targos we should include this in the backport PR |
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
This flag has been enabled by default since v8 7662e0634c3a057fa5d746912ee5af76e285c274. PR-URL: nodejs/node#16343 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
This flag has been enabled by default since v8 7662e0634c3a057fa5d746912ee5af76e285c274. PR-URL: nodejs/node#16343 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
BethGriggs pushed a commit to BethGriggs/node that referenced this pull request Jul 9, 2018
This flag has been enabled by default since v8 7662e0634c3a057fa5d746912ee5af76e285c274. PR-URL: nodejs#16343 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
2 tasks
addaleax pushed a commit that referenced this pull request Jul 11, 2018
This flag has been enabled by default since v8 7662e0634c3a057fa5d746912ee5af76e285c274. Backport-PR-URL: #21717 PR-URL: #16343 Reviewed-By: Anna Henningsen <[email protected]>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
This flag has been enabled by default since v8 7662e0634c3a057fa5d746912ee5af76e285c274. Backport-PR-URL: #21717 PR-URL: #16343 Reviewed-By: Anna Henningsen <[email protected]>
Merged
This was referenced May 13, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag has been enabled by default since v8 6.2.81.
Refs: v8/v8@7662e06
Checklist
Affected core subsystem(s)
test